Skip to content

New GoCollector metrics in 1.12 do not pass promtool check metrics lint #1026

Closed
@chancez

Description

@chancez

Using git tag v1.12.1, if we run promtool check metrics on our metrics we get the following failure:

go_gc_heap_allocs_by_size_bytes_total non-counter metrics should not have "_total" suffix
go_gc_heap_frees_by_size_bytes_total non-counter metrics should not have "_total" suffix
go_gc_pauses_seconds_total non-counter metrics should not have "_total" suffix

It seems that new metrics were potentially introduced in #955

I also filed prometheus/prometheus#10574 before realizing these are new metrics as part of a library upgrade, though it still seems useful in general.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions