mountstats/linux: fix multiple transports statistics labeling #3296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagigrimberg
force-pushed
the
sagi/fix-nfs-multi-xprt
branch
from
8516c15 to
e54568c
Compare
sagigrimberg
force-pushed
the
sagi/fix-nfs-multi-xprt
branch
3 times, most recently
from
46e6e08 to
bb2bc8c
Compare
|
Any chance to get this reviewed? |
|
cc @SuperQ |
|
ping? |
|
@SuperQ ? anyone? |
|
@discordianfish @SuperQ this PR is waiting idle ready. Any reason why it cannot be merged? |
When mounting nfs with nconnect, mountstats will show multiple transports. Currently the mountstats exporter fails to create metrics from this information due to repeated entries. Fix this by adding transport metrics a "transport" label enumerating their order in the mountstats output. Signed-off-by: Sagi Grimberg <[email protected]>
sagigrimberg
force-pushed
the
sagi/fix-nfs-multi-xprt
branch
from
bb2bc8c to
aa79888
Compare
|
@discordianfish @SuperQ this PR is ready for a couple of months now... Can we get it merged please? |
|
@discordianfish @SuperQ What is the reason you are ignoring this PR? Can you please either comment on what you would like to see changed or merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mounting nfs with nconnect, mountstats will show multiple transports. Currently the mountstats exporter fails to create metrics from this information due to repeated entries.
Fix this by adding transport metrics a "transport" label enumerating their order in the mountstats output.