Add forkAll combinator #45
Conversation
| forkAll :: forall f e a. (Foldable f) => f (Aff e a) -> Aff e Unit | ||
| ``` | ||
|
|
||
| Forks many asynchronous computation at once, ignoring the results. |
There was a problem hiding this comment.
It would be good to add a guarantee that all computations will be forked synchronously.
|
I went ahead and made it mirror |
|
@natefaubion 👍 Looks great, @garyb you want to do a final review? |
|
Will do, once 2.5 is out! |
| acc.push(aff(voidF, voidF)); | ||
| return acc; | ||
| } | ||
| })([])(affs); |
There was a problem hiding this comment.
Hah. I don't love it either :/
I might be able to extract out a helper to share with cancelWith.
On Feb 22, 2016, at 4:11 AM, Gary Burgess [email protected] wrote:
In src/Control/Monad/Aff.js:
@@ -96,6 +96,61 @@ exports._forkAff = function (nonCanceler, aff) {
};
}+exports._forkAll = function (nonCanceler, foldl, affs) {
- var voidF = function(){};
- return function(success, error) {
- var cancelers = foldl(function(acc) {
return function(aff) {acc.push(aff(voidF, voidF));return acc;}- })([])(affs);
—
Reply to this email directly or view it on GitHub.
There was a problem hiding this comment.
Nah, I can see it's fine, it's just the mutating of the array in the fold while constructing it that made me look twice. 😄
There was a problem hiding this comment.
Ah. Thought you were referring to the sheer length of this function. Hard to tell in email sometimes
|
Looks good to me too! 👍 |
No description provided.