add tryTakeVar and tryPeekVar #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
natefaubion
requested changes
May 8, 2017
src/Control/Monad/Aff/Internal.js
Outdated
| } else if (avar.producers.length > 0) { | ||
| avar.producers.shift()(function (x) { | ||
| success(just(x)); | ||
| return nonCanceler; |
There was a problem hiding this comment.
I don't think this is necessary. Judging by the other function (which just pass in success and error to the producer, this should just be equivalent to success <<< Just. Which means the JS should be:
avar.producers.shift()(function (x) {
return success(just(x));
}, error);Same for the tryPeekVar case.
There was a problem hiding this comment.
updated, i just using the style i see on FFI file for Aff.js, there _pure, _throwError return nonCanceller. But, i guess you are right, because _fmap in that file even doesn't return nonCanceller, nor return the return value
natefaubion
approved these changes
May 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #89