Created additional getFieldOptional #36
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regular getFieldOptional doesn't return Nothing when the value of the field is null. getFieldOptional' does give Nothing when the field is null. The operator aliasses are changed to mimic the Haskell Data.Aeson libraries implementation. (If, for legacy reasons, the alias for the old getFieldOptional shouldn't change, then switch (.??) for (.?!) and vice-versa.)
Added getFieldOptional' to Decode.Combinators
|
Hey @Vlix! Thanks for opening this PR. I'm sorry it's taken so long to hear a response. This is directly related to #32 and before merging I'd like to hear some opinions in that thread. @alebon -- I see you've endorsed this PR, so you might like to weigh in on that issue and the right approach as well. Either way, I hope to either merge this or something like it in the next week or so. Thanks for getting the ball rolling! |
|
Closed by #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into problems using
(.??)because it doesn't behave as expected if you're familiar with the Haskell Data.Aeson library.If the operator alias of the original
getFieldOptionalshouldn't change, use(.?!)for the new one.Maybe also change the name if
getFieldOptional'isn't clear enough.