fix some export problems from Data.String #42
Conversation
|
The usage of |
|
@michaelficarra like this (see the last commit bda7979)? test are all passing (see next comment) but I'm not sure if you want to drop the |
|
remark right now when I try this, I get an error from (filed an issue here: purescript-deprecated/purescript-strongcheck#51) also travis seem to fail because it's not using purs 0.12 |
|
latest commit should make travis use purs 0.12 - of course it still fails because of the issues with |
src/Data/Argonaut/Decode/Class.purs
Outdated
| @@ -12,7 +12,8 @@ import Data.Int (fromNumber) | |||
| import Data.List (List(..), (:), fromFoldable) | |||
| import Data.Map as M | |||
| import Data.Maybe (maybe, Maybe(..)) | |||
| import Data.String (charAt) | |||
| import Data.String (CodePoint) | |||
| import Data.String.CodePoints (codePointAt) | |||
There was a problem hiding this comment.
Is this not exported by Data.String?
There was a problem hiding this comment.
yes that's possible - I recheck and change (my tooling got broken, so I don't see the warnings right now)
There was a problem hiding this comment.
Looks to me like Data.String exports everything from Data.String.CodePoints: https://github.com/purescript/purescript-strings/blob/80dcf7ef362477214bee9082de091331576feb76/src/Data/String.purs
There was a problem hiding this comment.
I just changed this one minute ago :D
| install: | ||
| - TAG=$(wget -q -O - https://github.com/purescript/purescript/releases/latest --server-response --max-redirect 0 2>&1 | sed -n -e 's/.*Location:.*tag\///p') | ||
| - wget -O $HOME/purescript.tar.gz https://github.com/purescript/purescript/releases/download/$TAG/linux64.tar.gz |
There was a problem hiding this comment.
I presume this is just temporary until we can bump the dependency in package.json?
There was a problem hiding this comment.
yes - I'm not sure if I should include this at all - but it should fix the travis build/test for now (once the strongcheck issue got fixed upstream)
src/Data/Argonaut/Encode/Class.purs
Outdated
| encodeJson = encodeJson <<< singleton | ||
|
|
||
| instance encodeJsonChar :: EncodeJson Char where | ||
| encodeJson = encodeJson <<< codePointFromChar |
There was a problem hiding this comment.
You can just use the CodeUnit singleton here.
There was a problem hiding this comment.
ok thanks - gonna change this
|
Thanks! I cherry picked your changes in #43 |
|
Thank you - glad if I could help out a bit |
Data.Stringdon't exportsingleton : Char -> ...andcharAtanymore but it's inData.String.CodeUnitsusing these changes the package builds for me