Skip to content

Update to v0.15.0 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 22, 2022
Merged

Update to v0.15.0 #57

merged 13 commits into from
Mar 22, 2022

Conversation

JordanMartinez
Copy link
Contributor

Description of the change

Backlinking to purescript/purescript#4244

Migrates FFI to ES modules

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@JordanMartinez JordanMartinez added type: breaking change A change that requires a major version bump. purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 labels Mar 18, 2022
@JordanMartinez
Copy link
Contributor Author

🏓 @thomashoneyman

@JordanMartinez
Copy link
Contributor Author

Looks like I'll need to run that changelog generator on this repo.

thomashoneyman
thomashoneyman reviewed Mar 18, 2022
View reviewed changes
thomashoneyman
thomashoneyman reviewed Mar 18, 2022
View reviewed changes
@thomashoneyman
Copy link
Contributor

I’d be careful about making changes to the package.json file unless you want to make them to all projects that have that file, and have a backup method for the many contrib projects that don’t. If it’s possible to only change the ci.yml file then that’s going to be easier to implement across all these libraries.

@JordanMartinez
Copy link
Contributor Author

If it’s possible to only change the ci.yml file then that’s going to be easier to implement across all these libraries.

Yeah, that's what we'll do. Unfortunately, I'm not sure if I can script that.

@JordanMartinez
Copy link
Contributor Author

@thomashoneyman This is ready for another review.

@JordanMartinez JordanMartinez merged commit b86d346 into purescript-contrib:main Mar 22, 2022
@JordanMartinez JordanMartinez deleted the es-modules-libraries branch March 22, 2022 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
purs-0.15 A reminder to address this issue or merge this PR before we release PureScript v0.15.0 type: breaking change A change that requires a major version bump.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordanMartinez @thomashoneyman