Skip to content

Bump dependency versions #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2019
Merged

Conversation

davezuch
Copy link

What does this pull request do?

Bumps dependency versions of bundled libs.

Other Notes:

Should this lib even be maintained? Seems like so much extra work to keep all the packages in sync, but I think as long as it's published it should be kept up to date. Or somehow deprecated.

@thomashoneyman
Copy link

Thanks @davezuch!

I agree there's extra work in maintaining this package and keeping these versions together.

  • You can achieve the same result by installing the three Argonaut libraries directly, or by only installing the ones you are using.
  • Sometimes the three latest versions aren't compatible with other libraries, like when argonaut-traversals was not compatible with Halogen 4 but argonaut-core and argonaut-codecs were
  • Sometimes this library falls behind, so installing argonaut doesn't get you the latest versions of its constituent packages
  • Arguably the idea of letting you install all the Argonaut stuff with versions that work together could be equally well solved by just using a package set, though those are still not standard in PS yet

As far as arguments for keeping the package as-is, it's much friendlier to just install Argonaut rather than have to search for the three packages that make it up and install them separately. I'm not even sure the packages have obvious links to one another outside this one. A beginner would certainly have trouble figuring out what is meant to be installed with what.

Since the packages are already separate, I think it's worth keeping this one around just so people can install a single thing to get all Argonaut library code at once. We could also improve the readme by giving better descriptions of the constituent libraries and making a note that you can simply install the ones you need (typically core + codecs) directly if this one is out of sync with the versions you want.

@bosyi
Copy link

bosyi commented Mar 15, 2019

@thomashoneyman you write a lot of text but I did not understand, are you going to merge this?

Copy link
Member

@LiamGoodacre LiamGoodacre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thomashoneyman
Copy link

@bosyi Sorry -- yes, though I'd like to revisit that conversation in the future.

@thomashoneyman thomashoneyman self-assigned this Mar 15, 2019
@thomashoneyman thomashoneyman merged commit 3365736 into purescript-contrib:master Mar 15, 2019
@thomashoneyman
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants