Skip to content

Replace test-unit with assert and ReaderT #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 26, 2021
Merged

Replace test-unit with assert and ReaderT #11

merged 2 commits into from
Feb 26, 2021

Conversation

JordanMartinez
Copy link
Contributor

@JordanMartinez JordanMartinez commented Feb 26, 2021 •
edited
Loading

Description of the change

We forgot to remove the dependency on test-unit. This fixes that using the same approach used in other contrib repos.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

@JordanMartinez
Copy link
Contributor Author

This PR is failing because the prepare-0.14 branch in the package set changed the meta package to 0.13.8

@thomashoneyman thomashoneyman merged commit bf0f0a2 into purescript-contrib:main Feb 26, 2021
@JordanMartinez JordanMartinez deleted the fixTestUnitDep branch February 26, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JordanMartinez @thomashoneyman