Skip to content

fix YearFull parsing #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix YearFull parsing #24

wants to merge 1 commit into from

Conversation

safareli
Copy link
Contributor

@safareli safareli commented Jul 11, 2017 •
edited
Loading

continuation of #23

@safareli safareli requested a review from cryogenian July 11, 2017 16:52
@safareli
Copy link
Contributor Author

But with this change one can't have YYYYMM together. and moment.js works this way:

moment("00010220", "YYYYMMDD").format('YYYYMMDD') // 00010220

So I think previous version is better.

@safareli safareli closed this Jul 11, 2017
@safareli safareli deleted the year-length branch July 11, 2017 16:59
@safareli safareli mentioned this pull request Jul 11, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cryogenian cryogenian Awaiting requested review from cryogenian

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@safareli