Skip to content

Add weekday name format for DateTimes #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 11, 2017
Merged

Add weekday name format for DateTimes #31

merged 3 commits into from
Sep 11, 2017

Conversation

tippenein
Copy link
Contributor

@tippenein tippenein commented Aug 17, 2017

I wanted a weekday name rather than the index. These changes allow a format string such as "AA, MMM D" and return something like "Sunday, April 1". ("A" for "Sun")

Let me know if I missed something already in place to handle this formatting!

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2017

CLA assistant check
All committers have signed the CLA.

@safareli safareli requested a review from cryogenian August 18, 2017 16:21
Copy link
Contributor

@safareli safareli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@cryogenian what you think?

Copy link
Member

@garyb garyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This'll need releasing as a breaking change since it introduces new constructors. Looks good though!

@stefanholzmueller
Copy link

I like this functionality, too. Maybe the format tokens should be ddd and dddd though? See https://momentjs.com/docs/#/displaying/

@tippenein
Copy link
Contributor Author

@stefanholzmueller good call. I was going off strftime but seeing this momentjs table makes it pretty clear that was misguided.

@cryogenian
Copy link
Member

Thanks!

@cryogenian cryogenian merged commit 859e9f5 into purescript-contrib:master Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants