fix two digit trailing zeros < 0.10 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g., 2.05 with an after of 2 renders as "2.5" without this fix.
|
|
paulbjarne
changed the title
safareli
reviewed
Jan 18, 2018
| @@ -90,7 +90,9 @@ format ∷ Formatter → Number → String | |||
| format (Formatter f) num = | |||
| let | |||
| absed = Math.abs num | |||
| tens = if absed > 0.0 then Int.floor $ Math.log absed / Math.ln10 else 0 | |||
| tens = if absed > 0.0 | |||
| then max (Int.floor $ Math.log absed / Math.ln10) 0 | |||
There was a problem hiding this comment.
So the issue was that Math.log for anything less then 1.0, will return negative number
| @@ -118,6 +120,11 @@ format (Formatter f) num = | |||
| let | |||
| multiplier = Math.pow 10.0 $ Int.toNumber f.after | |||
| in Int.round $ leftover * multiplier | |||
| roundedWithZeros = | |||
There was a problem hiding this comment.
I don't understand this part, @cryogenian can you take a look?
There was a problem hiding this comment.
This adds zeros after comma/point and digits.
|
@paulbjarne Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two place decimal formatting after zero for < 0.10