Skip to content

Fix warnings #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2016
Merged

Fix warnings #26

merged 1 commit into from
Jan 21, 2016

Conversation

hdgarrood
Copy link
Contributor

This doesn't fix absolutely every warning; there are still two redundant
import warnings in Text.Parsing.Parser, arising from the imports of
Control.Monad.State.Class and Control.Monad.Trans.

Unfortunately, the compiler (0.7.6.1) is wrong; they are not redundant.
This is now fixed in the compiler, though, so these warnings should just
disappear after upgrading.

This doesn't fix absolutely every warning; there are still two redundant
import warnings in Text.Parsing.Parser, arising from the imports of
Control.Monad.State.Class and Control.Monad.Trans.

Unfortunately, the compiler (0.7.6.1) is wrong; they are not redundant.
This is now fixed in the compiler, though, so these warnings should just
disappear after upgrading.
@paf31
Copy link
Contributor

paf31 commented Dec 15, 2015

Looks good, but why move makeParser etc. out of the where?

@hdgarrood
Copy link
Contributor Author

Mainly because it was the easiest way to deal with all the shadowed type variables. But I generally prefer using top level declarations where possible, because when you have huge where clauses, any bindings in the where can use arguments bound in the top level declaration, which makes the way data is flowing around in the program a bit harder to follow, I think. There's more to keep in your head at once.

I checked that that module already has an explicit import list, so it won't lead to any new exports.

garyb added a commit that referenced this pull request Jan 21, 2016
@garyb garyb merged commit 60f4abb into purescript-contrib:master Jan 21, 2016
@hdgarrood hdgarrood deleted the warnings branch January 21, 2016 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants