Skip to content

Updates for psc 0.9.1 and dependencies. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2016

Conversation

jasonzoladz
Copy link
Contributor

No description provided.

@jasonzoladz
Copy link
Contributor Author

As you know, the current Travis build is set up with an old version of psc.

@jdegoes
Copy link
Contributor

jdegoes commented Jun 27, 2016

Hi @jasonzoladz. Thanks for the PR. :)

Can you please update the Travis build, too?

@jasonzoladz
Copy link
Contributor Author

Will do... A good opportunity to learn Travis. :)

On Mon, Jun 27, 2016 at 11:02 AM, John A. De Goes [email protected]
wrote:

Hi @jasonzoladz https://github.com/jasonzoladz. Thanks for the PR. :)

Can you please update the Travis build, too?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#23 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AIE1EMa7U40CkR4csjyi-jwasHHVa53-ks5qP-YWgaJpZM4I_Eg-
.

@garyb
Copy link
Member

garyb commented Jul 1, 2016

Looks like it's still spitting out warnings in the build, could you fix those too please?

In fact, could you use this package.json and this .travis.yml instead please? It will turn warnings into errors in the build, and also ensures we're not accidentally relying on dev dependencies for the library code.

@jasonzoladz
Copy link
Contributor Author

jasonzoladz commented Jul 1, 2016

Fixed warnings; updated .travis.yml; however, couldn't get pulp to pass the --strict or --censor-lib flag on to psc, so I didn't alter package.json.

@garyb
Copy link
Member

garyb commented Jul 1, 2016

Those flags are for purescript-psa, which is one of the dependencies added in that package.json 😄

@jasonzoladz
Copy link
Contributor Author

jasonzoladz commented Jul 1, 2016

Cool. I'll try again.

@jasonzoladz jasonzoladz force-pushed the master branch 2 times, most recently from 4d91e2e to a390354 Compare July 1, 2016 17:30
Modified test to not require browser environment.
@jasonzoladz
Copy link
Contributor Author

Should be set now. Thanks for the heads-up re: purescript-psa.

@garyb garyb merged commit 87f8809 into purescript-contrib:master Jul 4, 2016
@garyb
Copy link
Member

garyb commented Jul 4, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants