Skip to content

Empty hierarchical #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cryogenian
Copy link
Member

According to RFC3986 host = IP-literal / IPv4address / reg-name and reg-name = *( unreserved / pct-encoded / sub-delims ) and reg-name is used only for defining host.

@garyb please, please review

@garyb
Copy link
Member

garyb commented Feb 8, 2016

I'm not sure if this is the right way to handle this, wouldn't it be better to have an empty (Array (Tuple Host (Maybe Port))) instead?

You're totally right about the rule, but in general I think allowing empty string values isn't very "PureScripty", especially if it's a newtyped string.

I don't mind looking at this though, as there are two other parser issues I know of that need fixing for sure too, so I can do that at the same time.

@cryogenian
Copy link
Member Author

Ok, switched to empty array.

@garyb garyb added ready and removed in review labels Feb 8, 2016
@garyb
Copy link
Member

garyb commented Feb 8, 2016

👍

@garyb
Copy link
Member

garyb commented Feb 8, 2016

Can you squash before merging please?

@cryogenian
Copy link
Member Author

Sure

@cryogenian
Copy link
Member Author

Shall I release this as 0.2.2?

cryogenian added a commit that referenced this pull request Feb 8, 2016
@cryogenian cryogenian merged commit 7d0e872 into purescript-contrib:master Feb 8, 2016
@garyb
Copy link
Member

garyb commented Feb 8, 2016

I'll open a PR for my other parser fix first actually. Should only take about 5 mins, I have the change already as part of a bigger thing, but the rest of it needs more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants