Skip to content

Authority part parsing fixes #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2016

Conversation

garyb
Copy link
Member

@garyb garyb commented Feb 8, 2016

@cryogenian could you review this please?

The change here is that the parsers that optionally accept an Authority would always fail when the authority was not present, as they're supposed to branch depending on whether the authority is present, but instead had an optionMaybe in there.

Fixing the parser this way enables the test cases for ../top_story.htm and top_story.htm to pass successfully now too.

Also a tweak to the pretty printer: usually we'd probably write "foo.htm" rather than "./foo.htm" for a relative file path, but with pathy's normal pretty printing we were getting the latter.

@cryogenian
Copy link
Member

👍

@garyb
Copy link
Member Author

garyb commented Feb 8, 2016

Thanks!

garyb added a commit that referenced this pull request Feb 8, 2016
@garyb garyb merged commit f0ef953 into purescript-contrib:master Feb 8, 2016
@garyb garyb deleted the auth-part-parsing branch February 8, 2016 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants