This repository was archived by the owner on Oct 4, 2020. It is now read-only.
Add code from eff-functions #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
approved these changes
Mar 31, 2017
|
Yep, that's fine by me. |
|
Actually, @hdgarrood, would you mind modifying the LICENSE file if you'd like it to be modified? I think we should also discuss what the copyright notices should say/mean, at some point. It's not clear to me what "PureScript" identifies. |
|
I'm happy leaving the license file in this repo as it is regarding these changes. In the longer term, do you think it would make sense to list contributors' names instead of just writing "PureScript"? |
|
Yes, I would prefer that. I've been thinking the same recently :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is copied verbatim, just changing the module name and adding some spacing in the comments.
@hdgarrood The original code has no license file, so I inferred the MIT license from the
bower.jsonfile? I'll add that to the LICENSE file here if you can just confirm that's okay.