Remove primes from foreign modules exports #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdgarrood
reviewed
Mar 14, 2020
| @@ -100,7 +100,10 @@ foreign import concat :: Array ImmutableBuffer -> ImmutableBuffer | |||
|
|
|||
| -- | Concatenates a list of buffers, combining them into a new buffer of the | |||
| -- | specified length. | |||
| foreign import concat' :: Array ImmutableBuffer -> Int -> ImmutableBuffer | |||
There was a problem hiding this comment.
Can you move the doc-comment to the version of this we are going to export please?
There was a problem hiding this comment.
Well spotted! I just did that.
kl0tl
force-pushed
the
no-foreign-primes
branch
from
6ec4ce1 to
062ed3e
Compare
kl0tl
force-pushed
the
no-foreign-primes
branch
from
062ed3e to
ef22fae
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primes in foreign modules exports will be deprecated in v0.14.0. See purescript/purescript#3792.