Skip to content

Add null support for data property of InputEvent #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2023

Conversation

kobijones111529
Copy link
Contributor

@kobijones111529 kobijones111529 commented Apr 11, 2023

Description of the change

Change InputEvent data_ FFI import to private _data_ function returning type Nullable String to accommodate null data property. Export data_ function, now returning type Maybe String.


Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@garyb
Copy link
Member

garyb commented Sep 24, 2023

Thanks! Sorry about the ridiculously long delay before merging.

@garyb garyb merged commit 8144c37 into purescript-web:master Sep 24, 2023
@kobijones111529
Copy link
Contributor Author

Thanks! Sorry about the ridiculously long delay before merging.

No worries! Happy to make a contribution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants