Skip to content

reexport Data.String.CodeUnits #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

CarstenKoenig
Copy link

those reexports are missing - for example charAt is not found right now

those reexports are missing - for example `charAt` is not found right now
@garyb
Copy link
Member

garyb commented May 28, 2018

charAt and the like don't really make sense to re-export, as none of the other functions will able to use Char. Importing CodeUnits explicitly for the Char functions was the intention.

@CarstenKoenig
Copy link
Author

ok I see - I already adapted the one occurrence I found (purescript-contrib/purescript-argonaut-codecs#42) - sorry to bother you - I guess I should close this then

@CarstenKoenig CarstenKoenig deleted the patch-1 branch May 28, 2018 19:15
@michaelficarra
Copy link
Contributor

@CarstenKoenig This is actually a really good thing. This will help people find Unicode bugs in their projects. For instance, the usages of charAt in purescript-contrib/purescript-argonaut-codecs#42 are actually bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants