Skip to content

add statement re ending python 2.7 support on June 1 2019 #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

wholmgren
Copy link
Member

@wholmgren wholmgren commented Aug 10, 2018

  • Closes Plan for dropping Python 2.7 #501
  • I am familiar with the contributing guidelines.
  • Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.
  • Updates entries to docs/sphinx/source/api.rst for API changes.
  • Adds description and name entries in the appropriate docs/sphinx/source/whatsnew file for all changes.
  • Code quality and style is sufficient. Passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.
  • Pull request is nearly complete and ready for detailed review.

Brief description of the problem and proposed solution (if not already fully described in the issue linked to above):

@wholmgren wholmgren added this to the 0.6.0 milestone Aug 10, 2018
Copy link
Member

@mikofski mikofski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 hooray!

@wholmgren wholmgren merged commit 9ead2f2 into pvlib:master Aug 14, 2018
wholmgren added a commit to wholmgren/python3statement.github.io that referenced this pull request Aug 14, 2018
Carreau pushed a commit to python3statement/python3statement.github.io that referenced this pull request Aug 14, 2018
@wholmgren wholmgren deleted the droppy2 branch August 28, 2018 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants