-
Notifications
You must be signed in to change notification settings - Fork 1.1k
avoid and silence warnings #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of format fixes !
Warnings status:
To do:
Yeah :( Trying to strike a compromise with my IDE's linter. The stickler objections here are wrong. Maybe a flake8 bug. |
pvlib/test/test_irradiance.py
Outdated
warnings.simplefilter("ignore") | ||
result = irradiance.get_extra_radiation(times, method='nrel', | ||
how='numba', | ||
numthreads=4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since you're making formatting changes, possibly consider:
result = irradiance.get_extra_radiation(
times, method='nrel', how='numba', numthreads=4)
this is blacker code, tho not quite completely Black
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree this better formatting in this case. Overall, I prefer the grey zone.
Everything lgtm so far, thanks! |
@cwhanse ready to merge if you approve of the last few commits. I'd like to keep the |
docs/sphinx/source/api.rst
for API changes.docs/sphinx/source/whatsnew
file for all changes.Avoid or silence a lot of test warnings, plus a few that users might encounter (
klucher
andcalcparams_desoto
divide by 0).Also some pep8 along the way. Waiting on #697.