-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Drop Python 2 and 3.4 #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
91e1482
6207754
5dafd6c
e381237
ef4168d
554c104
7406bb1
3854746
990ea4e
507428f
391cf72
11408e6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
name: test_env | ||
channels: | ||
- defaults | ||
dependencies: | ||
- coveralls | ||
- nose | ||
- numpy=1.10.1 | ||
- pandas=0.18.0 | ||
- pip | ||
- pytest | ||
- pytest-cov | ||
- pytest-mock | ||
- pytest-timeout | ||
- python=3.5 | ||
- pytz | ||
- requests |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,21 +3,25 @@ channels: | |
- defaults | ||
- conda-forge | ||
dependencies: | ||
- python=3.5 | ||
- numpy | ||
- scipy | ||
- pytables | ||
- pandas | ||
- pytz | ||
- coveralls | ||
- cython | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. why cython? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, I forgot it's in the setup.py extras section. I can't remember why it's there. I guess it should be here if it's in the setup.py file. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I tried to make all the non-min requirements files match the |
||
- ephem | ||
- netcdf4 | ||
- nose | ||
- numba | ||
- siphon | ||
- numpy | ||
- pandas | ||
- pip | ||
- pytables # tables when using pip+PyPI | ||
- pytest | ||
- pytest-cov | ||
- nose | ||
- pytest-mock | ||
- pytest-timeout | ||
- python=3.5 | ||
- pytz | ||
- requests | ||
- scipy | ||
- shapely # pvfactors dependency | ||
- siphon # conda-forge | ||
- pip: | ||
- coveralls | ||
- pytest-mock | ||
- pytest-timeout | ||
- pvfactors==1.0.1 |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
.. _whatsnew_0700: | ||
|
||
v0.7.0 (MONTH DAY, YEAR) | ||
--------------------- | ||
|
||
This is a major release that drops support for Python 2 and Python 3.4. We | ||
recommend all users of v0.6.3 upgrade to this release. | ||
|
||
**Python 2.7 support ended on June 1, 2019**. (:issue:`501`) | ||
|
||
|
||
Contributors | ||
~~~~~~~~~~~~ | ||
* Mark Campanellli (:ghuser:`markcampanelli`) | ||
* Will Holmgren (:ghuser:`wholmgren`) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,4 @@ | ||
import sys | ||
try: | ||
from unittest.mock import ANY | ||
except ImportError: | ||
# python 2 | ||
from mock import ANY | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Apparently, this is not used. |
||
|
||
import numpy as np | ||
import pandas as pd | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wholmgren Do we need to define a new minimum environment in Python 3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good catch. I'm pretty sure you'll be able to pin the minimum version numbers in the pip section of the file. I'm less sure about the conda section of the file. Either way is fine with me. I don't think we'll need anything special after that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I was wrong -- I'm not able to easily create a python 3.5 environment with the current numpy/pandas minimums on my mac. I suspect it's possible but I don't think it's worth the effort to struggle against theses old packages. I can easily build and test the environment with pandas 0.17:
We should also specify a newer version of conda in the travis config. Latest is fine.
Only catch is that
test_sun_rise_set_transit_spa
claims it needs pandas 0.17, but it apparently needs 0.18.