Answers chp 11 #43
Merged
Answers chp 11 #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on ReviewNB: https://app.reviewnb.com/pymc-devs/resources/pull/43 You'll be able to see visual diffs and write comments on notebook cells. Powered by ReviewNB. |
aloctavodia
reviewed
Jun 30, 2019
|
I think we can merge if we open and issue to remind us to revisit the ordered categorical model in problem 11H5. What do you think @AlexAndorra? |
|
Agreed Osvaldo! Let me adjust and push the NB in that sense tomorrow. I'll
open the issue right after that 😉
I think we can do the same thing for chapter 12 (ready to merge, but last 2
problems need Ordered Logistic) if it's fine by you?
Le mer. 3 juil. 2019 à 17:22, Osvaldo Martin <[email protected]> a
écrit :
… I think we can merge if we open and issue to remind us to revisit the
ordered categorical model in problem 11H5. What do you think @AlexAndorra
<https://github.com/AlexAndorra>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#43>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHIJMTAGE2L6XWMUZKWBXTLP5S72BANCNFSM4H4INAQQ>
.
|
|
Totally fine! Thanks. |
|
Ready for merge and opened the issue as a reminder, as discussed :) |
rosgori
pushed a commit
to rosgori/resources
that referenced
this pull request
Dec 3, 2019
* Started working on chapter 11 answers * Continued chapter 11 problems * Finished chapter 11 problems - modulo problem 11H5 and question at end of 11H6 * Fixed typos in ch-11 practice problems * Prepared ch-11 NB for PR * Removed blank lines in fish.csv and hurricanes.csv * Better posterior predictive sampling in 11H6 * ch-11 NB ready for PR except 11H5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first version of chapter 11 solutions.
As discussed with @aloctavodia this is not ready to merge yet, mainly because of sampling problems in ordered categorical model (problem 11H5) and a question about posterior predictive samples (see end of problem 11H6).
Will do the necessary updates after review.
Thanks in advance,
PyMCheers !