Parametrize shape and size tests #3099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We used it somewhere else in the test and indeed it is a much better way. |
|
Looks good - thanks @canyon289 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on this pull request #3060, one challenge I'm having is that its really three tests rolled into one. This makes it hard to develop though because if "test 2" fails I can't see the result of test 3.
pytest has a handy parameterize decorator that takes a single tests definition and converts it into N number of independent tests. To me this makes things easier since each assert gets its own pass/fail line
Hopefully this helps make the testing suite more clear to others as well, let me know what you think!
If this change is welcome I can also comb through all the tests and see where else parametrize can be applied