Skip to content

Do not generate C code for BatchedDot when BLAS flags are missing #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pytensor/tensor/blas.py
Original file line number Diff line number Diff line change
Expand Up @@ -1795,6 +1795,10 @@ def c_header_dirs(self, **kwargs):
return ldflags(libs=False, include_dir=True)

def c_code(self, node, name, inp, out, sub):
# Can only compile if linked to blas libraries
if len(self.c_libraries()) <= 0:
raise NotImplementedError()

_x, _y = inp
(_z,) = out
fail = sub["fail"]
Expand Down
25 changes: 25 additions & 0 deletions tests/tensor/test_blas.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from pytensor.tensor import inplace
from pytensor.tensor.basic import as_tensor_variable
from pytensor.tensor.blas import (
BatchedDot,
Dot22,
Dot22Scalar,
Gemm,
Expand Down Expand Up @@ -2700,6 +2701,30 @@ def check_first_dim(inverted):
check_first_dim(inverted)


def test_batched_dot_blas_flags():
"""Test that BatchedDot works regardless of presence of BLAS flags"""
mode = "FAST_RUN"
rng = np.random.default_rng(2708)

x = tensor("x", shape=(2, 5, 3))
y = tensor("y", shape=(2, 3, 1))
out = batched_dot(x, y)
assert isinstance(out.owner.op, BatchedDot)
x_test = rng.normal(size=x.type.shape).astype(x.type.dtype)
y_test = rng.normal(size=y.type.shape).astype(y.type.dtype)

fn = function([x, y], out, mode=mode)
[batched_dot_thunk] = fn.vm.thunks
assert hasattr(batched_dot_thunk, "cthunk")
np.testing.assert_allclose(fn(x_test, y_test), x_test @ y_test)

with config.change_flags(blas__ldflags=""):
fn = function([x, y], out, mode=mode)
[batched_dot_thunk] = fn.vm.thunks
assert not hasattr(batched_dot_thunk, "cthunk")
np.testing.assert_allclose(fn(x_test, y_test), x_test @ y_test)


def test_batched_tensordot():
rng = np.random.default_rng(unittest_tools.fetch_seed())
first = tensor4("first")
Expand Down