Skip to content

include 3.8.0rc1 in manylinux1 #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 7, 2019
Merged

include 3.8.0rc1 in manylinux1 #360

merged 4 commits into from
Oct 7, 2019

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Oct 3, 2019

Repeat gh-344 for the manylinux1 branch

@mattip
Copy link
Contributor Author

mattip commented Oct 3, 2019

The gpg --recv-keys command is failing:

gpg: requesting key 10250568 from hkp server subkeys.pgp.net
gpg: keyserver timed out
gpg: keyserver receive failed: keyserver error

On gh-344 the same --recv-key command printed

gpg: requesting key 10250568 from hkp server keys.gnupg.net
gpg: key 10250568: public key ... imported
gpg: no ultimately trusted keys found
gpg: Total number processed: 1
gpg:               imported: 1  (RSA: 1)

How do I change the keyserver to keys.gnupg.net?

@mattip
Copy link
Contributor Author

mattip commented Oct 4, 2019

using the full key worked

Copy link
Member

@trishankatdatadog trishankatdatadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattip Good, full key IDs protect us from collisions attacks, too

Please add the --no-auto-key-locate option to gpg verify here: this should prevent GPG from "helpfully" downloading public keys we did not specifically download

@mattip
Copy link
Contributor Author

mattip commented Oct 5, 2019

added requested flag

@mattip
Copy link
Contributor Author

mattip commented Oct 5, 2019

why does this sometimes succeed, sometimes fail?

gpg --keyserver keys.gnupg.net --recv-keys \
E3FF2839C048B25C084DEBE9B26995E310250568

@mattip
Copy link
Contributor Author

mattip commented Oct 7, 2019

That time it worked. Should we reopen again to make sure it was a once-off fluke?

@auvipy
Copy link
Contributor

auvipy commented Oct 7, 2019

now its passing

@auvipy auvipy merged commit 61d3701 into pypa:manylinux1 Oct 7, 2019
@mattip mattip deleted the 3.8.0rc1 branch March 19, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants