Skip to content

Use types_or for the check-meltano hook #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Mar 26, 2025

Just noticed, sorry about that 😅.

I don't think there's a way to test it, but I'd be happy to give it a try.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review March 26, 2025 02:04
@sirosen
Copy link
Member

sirosen commented Mar 26, 2025

No worries, I missed it as well! Let's go ahead and ship this fix as a patch release.

It is possible to run locally installed hooks with pre-commit, but I can't think of a way of using that to test things other than to setup a CI job which builds full mock repos. Maybe a fun project some time when I'm not so busy! 😁

@sirosen sirosen merged commit 512fcad into python-jsonschema:main Mar 26, 2025
23 checks passed
@edgarrmondragon edgarrmondragon deleted the check-meltano-types_or branch March 26, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants