Split up _testinternalcapi.c

[colesbury]

#93649 and associated PRs split up _testcapimodule.c because the file is large and hard to maintain. I'm proposing splitting the tests for the internal C API (Modules/_testinternalcapi.c) in the same manner for the same reasons. Additionally, I expect the PRs related to PEP 703 to require additional internal C API tests, and I'd like to avoid further cluttering _testinternalcapi.c.

cc @encukou @vstinner

Linked PRs

• gh-108777: Split _PyTime tests from _testinternalcapi.c #108787

[rhettinger]

I don't think this is worthwhile. In some ways, having lots of smaller files is its own bit of hassle. Our editors are powerful enough to make it easy to work with a single large file.

[colesbury]

To be clear, I am not proposing breaking up _testinternalcapi.c entirely, only where there's enough related tests to make it worthwhile. I'm not proposing lots of smaller files. I'm proposing a few smaller files that contain test code for related bits of the internal C API, such as for testing the locks and other synchronization primitives in #108724.

[erlend-aasland]

#93649 and associated PRs split up _testcapimodule.c because the file is large and hard to maintain. I'm proposing splitting the tests for the internal C API (Modules/_testinternalcapi.c) in the same manner for the same reasons. Additionally, I expect the PRs related to PEP 703 to require additional internal C API tests, and I'd like to avoid further cluttering _testinternalcapi.c.

Sounds reasonable to me; there's been various efforts the last years that have split up large and unmaintainable files (both .py and .c files) into maintainable chunks.

[vstinner]

Can you give a prototype (list of sections) of how you would like to split this C extension? Does it change the Python test_capi test package?

[colesbury]

For now, I'd just move the 12 _PyTime tests to their own file. And I'd put the lock-related tests for #108724 in their own file. It would not change the Python test_capi package.

[erlend-aasland]

For now, I'd just move the 12 _PyTime tests to their own file.

Do you want to keep this open?

[colesbury]

I think we can close this.