Maxheap version of a heappush

[coopers]

Feature or enhancement

Proposal:

def _heappush_max(heap, item):
    """Maxheap version of a heappush."""
    heap.append(item)
    _siftdown_max(heap, 0, len(heap)-1)

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

conversation on making max heap functions public

Linked PRs

• gh-110067: Add maxheap version of heappush. #110068
• gh-110067: Make max heap methods public and add missing ones #130725

[encukou]

Functions with a leading underscore are private -- i.e. _heappush_max should not be used outside heapq itself. It should be named without an underscore, and it would also need documentation and tests.

Raymond said he's working on public maxheap functions. If you'd like to work on this, perhaps ask if he's still on it.

[rhettinger]

Yes, I've still got this.

[tnightengale]

@rhettinger 👋 Would you like any help on this? Recently I reached for a max-heap in python and was surprised it didn't exist. Saw this thread and wondered if this is still on anyone's radar, since it was not released with 3.13.

[Teut2711]

Anyone still working on it ?

[StanFromIreland]

This can be closed now. I will add some further documentation updates in a follow up.

[encukou]

You could reuse this issue.

[StanFromIreland]

I had already created #133530, apologies, it just seemed a bit messy to use this one since there is a lot of unrelated comments.