fix(editorconfig): do not use inline comment #106610

e-kwsm · 2023-07-10T22:55:32Z

This change is quite trivial, but inline comments are no longer valid since EditorConfig version 0.15.0. See

Alternatively, the comment can be removed since the meaning is quite obvious.

It is no longer valid since 0.15.0 <https://github.com/editorconfig/specification/blob/v0.15/index.rst#no-inline-comments>

miss-islington · 2023-07-11T14:55:41Z

Thanks @e-kwsm for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

bedevere-bot · 2023-07-11T14:55:51Z

GH-106630 is a backport of this pull request to the 3.12 branch.

It is no longer valid since 0.15.0 https://github.com/editorconfig/specification/blob/v0.15/index.rstGH-no-inline-comments (cherry picked from commit 64c0890) Co-authored-by: Eisuke Kawashima <[email protected]>

bedevere-bot · 2023-07-11T14:55:55Z

GH-106631 is a backport of this pull request to the 3.11 branch.

bedevere-bot · 2023-07-11T15:44:43Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Non-Debug with X 3.x has failed when building commit 64c0890.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/58/builds/5113) and take a look at the build logs.
Check if the failure is related to this commit (64c0890) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/58/builds/5113

Failed tests:

test_io

Failed subtests:

test_nonblock_pipe_write_smallbuf - test.test_io.PyMiscIOTest.test_nonblock_pipe_write_smallbuf
test_daemon_threads_shutdown_stderr_deadlock - test.test_io.CMiscIOTest.test_daemon_threads_shutdown_stderr_deadlock
test_daemon_threads_shutdown_stdout_deadlock - test.test_io.CMiscIOTest.test_daemon_threads_shutdown_stdout_deadlock
test_nonblock_pipe_write_bigbuf - test.test_io.PyMiscIOTest.test_nonblock_pipe_write_bigbuf
test_readinto_buffer_overflow - test.test_io.CMiscIOTest.test_readinto_buffer_overflow
test_nonblock_pipe_write_smallbuf - test.test_io.CMiscIOTest.test_nonblock_pipe_write_smallbuf
test_text_encoding - test.test_io.PyMiscIOTest.test_text_encoding
test_nonblock_pipe_write_bigbuf - test.test_io.CMiscIOTest.test_nonblock_pipe_write_bigbuf
test_text_encoding - test.test_io.CMiscIOTest.test_text_encoding

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

430 tests OK.

10 slowest tests:

test_concurrent_futures: 2 min 5 sec
test_multiprocessing_spawn: 1 min 19 sec
test_signal: 1 min 9 sec
test_multiprocessing_forkserver: 1 min 6 sec
test_multiprocessing_fork: 1 min 1 sec
test_hashlib: 36.1 sec
test_imaplib: 30.9 sec
test_io: 29.5 sec
test_xmlrpc: 27.3 sec
test_subprocess: 25.3 sec

1 test failed:
test_io

14 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_gdb
test_ioctl test_kqueue test_launcher test_perf_profiler
test_startfile test_winconsoleio test_winreg test_winsound
test_wmi test_zipfile64

2 re-run tests:
test_io test_socket

1 test run no tests:
test_socket

Total duration: 44 min 5 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_io.py", line 4265, in test_nonblock_pipe_write_smallbuf
    self._test_nonblock_pipe_write(1024)
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_io.py", line 4298, in _test_nonblock_pipe_write
    received.append(rf.read())
                    ^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/_pyio.py", line 1056, in read
    return self._read_unlocked(size)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/_pyio.py", line 1068, in _read_unlocked
    chunk = self.raw.readall()
            ^^^^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/_pyio.py", line 1674, in readall
    result += chunk
MemoryError


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_io.py", line 4265, in test_nonblock_pipe_write_smallbuf
    self._test_nonblock_pipe_write(1024)
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_io.py", line 4298, in _test_nonblock_pipe_write
    received.append(rf.read())
                    ^^^^^^^^^
MemoryError


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_io.py", line 4427, in test_readinto_buffer_overflow
    self.assertRaises(ValueError, bufio.readinto, b)
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/case.py", line 778, in assertRaises
    return context.handle('assertRaises', args, kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/unittest/case.py", line 238, in handle
    callable_obj(*args, **kwargs)
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_io.py", line 4424, in read
    return b'x' * 10**6
           ~~~~~^~~~~~~
MemoryError


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_io.py", line 4476, in test_daemon_threads_shutdown_stderr_deadlock
    self.check_daemon_threads_shutdown_deadlock('stderr')
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_io.py", line 4457, in check_daemon_threads_shutdown_deadlock
    res, _ = run_python_until_end("-c", code)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/support/script_helper.py", line 139, in run_python_until_end
    out, err = proc.communicate()
               ^^^^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/subprocess.py", line 1209, in communicate
    stdout, stderr = self._communicate(input, endtime, timeout)
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/subprocess.py", line 2128, in _communicate
    data = os.read(key.fd, 32768)
           ^^^^^^^^^^^^^^^^^^^^^^
MemoryError


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_io.py", line 4259, in test_nonblock_pipe_write_bigbuf
    self._test_nonblock_pipe_write(16*1024)
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_io.py", line 4298, in _test_nonblock_pipe_write
    received.append(rf.read())
                    ^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/_pyio.py", line 1056, in read
    return self._read_unlocked(size)
           ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/_pyio.py", line 1068, in _read_unlocked
    chunk = self.raw.readall()
            ^^^^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/_pyio.py", line 1674, in readall
    result += chunk
MemoryError


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_io.py", line 4259, in test_nonblock_pipe_write_bigbuf
    self._test_nonblock_pipe_write(16*1024)
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_io.py", line 4298, in _test_nonblock_pipe_write
    received.append(rf.read())
                    ^^^^^^^^^
MemoryError


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_io.py", line 4472, in test_daemon_threads_shutdown_stdout_deadlock
    self.check_daemon_threads_shutdown_deadlock('stdout')
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_io.py", line 4457, in check_daemon_threads_shutdown_deadlock
    res, _ = run_python_until_end("-c", code)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/support/script_helper.py", line 134, in run_python_until_end
    proc = subprocess.Popen(cmd_line, stdin=subprocess.PIPE,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/subprocess.py", line 1906, in _execute_child
    part = os.read(errpipe_read, 50000)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
MemoryError


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/test_io.py", line 4410, in test_text_encoding
    proc = assert_python_ok('-X', 'utf8=0', '-c', code)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/support/script_helper.py", line 166, in assert_python_ok
    return _assert_python(True, *args, **env_vars)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/support/script_helper.py", line 149, in _assert_python
    res, cmd_line = run_python_until_end(*args, **env_vars)
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/test/support/script_helper.py", line 134, in run_python_until_end
    proc = subprocess.Popen(cmd_line, stdin=subprocess.PIPE,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/buildbot/buildarea/cpython/3.x.ware-gentoo-x86.nondebug/build/Lib/subprocess.py", line 1906, in _execute_child
    part = os.read(errpipe_read, 50000)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
MemoryError

It is no longer valid since 0.15.0 https://github.com/editorconfig/specification/blob/v0.15/index.rstGH-no-inline-comments (cherry picked from commit 64c0890) Co-authored-by: Eisuke Kawashima <[email protected]>

bedevere-bot added the awaiting review label Jul 10, 2023

fix(editorconfig): do not use inline comment

5d79f86

It is no longer valid since 0.15.0 <https://github.com/editorconfig/specification/blob/v0.15/index.rst#no-inline-comments>

e-kwsm force-pushed the editorconfig branch from 2403ee3 to 5d79f86 Compare July 10, 2023 22:58

methane approved these changes Jul 11, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Jul 11, 2023

methane added skip issue skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 11, 2023

methane merged commit 64c0890 into python:main Jul 11, 2023

bedevere-bot removed the awaiting merge label Jul 11, 2023

bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 11, 2023

bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 11, 2023

e-kwsm deleted the editorconfig branch July 11, 2023 19:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(editorconfig): do not use inline comment #106610

fix(editorconfig): do not use inline comment #106610

Uh oh!

e-kwsm commented Jul 10, 2023

Uh oh!

miss-islington commented Jul 11, 2023

Uh oh!

bedevere-bot commented Jul 11, 2023

Uh oh!

bedevere-bot commented Jul 11, 2023

Uh oh!

bedevere-bot commented Jul 11, 2023

Uh oh!

Uh oh!

Uh oh!

fix(editorconfig): do not use inline comment #106610

fix(editorconfig): do not use inline comment #106610

Uh oh!

Conversation

e-kwsm commented Jul 10, 2023

Uh oh!

miss-islington commented Jul 11, 2023

Uh oh!

bedevere-bot commented Jul 11, 2023

Uh oh!

bedevere-bot commented Jul 11, 2023

Uh oh!

bedevere-bot commented Jul 11, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!