-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
gh-66143: Allow copying of CodecInfo object #109235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
e2b6a32
implement __getnewargs__ for codecs to use copy module
furkanonder e71ea50
test duplicated codec with the original codec
furkanonder c722e52
Merge branch 'main' into issue-66143
furkanonder 089d89c
📜🤖 Added by blurb_it.
blurb-it[bot] dbe168b
add test for deepcopy
furkanonder 93070e8
Merge branch 'issue-66143' of github.com:furkanonder/cpython into iss…
furkanonder 271de81
add pickle test for CodecInfo
furkanonder dff8e3c
add tests for a CodecInfo with _is_text_encoding equal to False
furkanonder 6de32a6
Merge branch 'main' into issue-66143
furkanonder 8c015be
remove white spaces
furkanonder bddde11
Merge branch 'issue-66143' of github.com:furkanonder/cpython into iss…
furkanonder f887190
add tests for a CodecInfo with _is_text_encoding equal to False
furkanonder cfc691c
remove white spaces
furkanonder 73fec7d
update function name as test_deepcopy
furkanonder d8300cf
add equality test to test_copy
furkanonder bb6f4ba
add equality check to test methods
furkanonder f3d87eb
use base64 instead of rot13
furkanonder afea5b9
check name, incrementalencoder and _is_text_encoding in pickle test c…
furkanonder 807dfd4
add assertIsNot check to pickle tests
furkanonder e3c6ce3
use base64 instead of rot13
furkanonder ef0df6a
add equality check to test methods
furkanonder 026d1e2
add equality check to test methods
furkanonder 9c12be6
Update 2023-09-10-20-23-20.gh-issue-66143.71xvgL.rst
serhiy-storchaka f0ea5c7
fix typo in news entry
furkanonder File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Library/2023-09-10-20-23-20.gh-issue-66143.71xvgL.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
The :class:`codecs.CodecInfo` object has been made copyable and pickleable. | ||
Patched by Robert Lehmann and Furkan Onder. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.