Skip to content

gh-116869: Fix test_cext on RHEL7 #117010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2024
Merged

gh-116869: Fix test_cext on RHEL7 #117010

merged 2 commits into from
Mar 19, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 19, 2024

Remove -std option from CC command line.

Remove -std option from CC command line.
@vstinner
Copy link
Member Author

!buildbot s390x RHEL7

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit 056b605 🤖

The command will test the builders whose names match following regular expression: s390x RHEL7

The builders matched are:

  • s390x RHEL7 PR
  • s390x RHEL7 LTO + PGO PR
  • s390x RHEL7 LTO PR
  • s390x RHEL7 Refleaks PR

@vstinner
Copy link
Member Author

I fixed the first issue, but building for C++14 failed:

exit code: 1
  ╰─> [13 lines of output]
      CC env var: 'gcc -pthread'
      CFLAGS env var: <missing>
      CPPFLAGS env var: <missing>
      extra_compile_args: ['-Werror', '-DMODULE_NAME=_testcpp14ext', '-std=c++14']
      running bdist_wheel
      running build
      running build_ext
      building '_testcpp14ext' extension
      creating build
      creating build/temp.linux-s390x-cpython-313-pydebug
      gcc -pthread -fno-strict-overflow -Wsign-compare -g -Og -Wall -fPIC -I/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z/build/build/test_python_25841æ/tempcwd/env/include -I/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z/build/Include -I/home/dje/cpython-buildarea/pull_request.edelsohn-rhel-z/build -c extension.cpp -o build/temp.linux-s390x-cpython-313-pydebug/extension.o -Werror -DMODULE_NAME=_testcpp14ext -std=c++14
      gcc: error: unrecognized command line option ‘-std=c++14’
      error: command '/usr/bin/gcc' failed with exit code 1
      [end of output]

@vstinner
Copy link
Member Author

!buildbot s390x RHEL7 PR

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @vstinner for commit fc70715 🤖

The command will test the builders whose names match following regular expression: s390x RHEL7 PR

The builders matched are:

  • s390x RHEL7 PR

@vstinner vstinner merged commit 438de10 into python:main Mar 19, 2024
vstinner added a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
Remove -std option from CC command line.

Skip C++14 test for now on non-Windows platforms (like RHEL7).
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
Remove -std option from CC command line.

Skip C++14 test for now on non-Windows platforms (like RHEL7).
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Remove -std option from CC command line.

Skip C++14 test for now on non-Windows platforms (like RHEL7).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants