bpo-36003: change socketserver.TCPServer reuse_addr and backlog default options #11875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- allow_reuse_address from False to True on POSIX - request_queue_size from 5 to 0
matrixise
requested changes
Feb 15, 2019
taleinat
reviewed
Jun 8, 2019
|
|
||
| allow_reuse_address = False | ||
| allow_reuse_address = \ | ||
| os.name not in ('nt', 'cygwin') and hasattr(socket, 'SO_REUSEADDR') |
There was a problem hiding this comment.
Why the OS check here? Is SO_REUSEADDR available but not appropriate for use on Windows? If so, I suggest adding a comment.
Also, why use os.name rather than sys.platform?
|
@vstinner, why did you close this with no comment, while the bpo issue is still open? |
|
Could this be due to the renaming of the "master" branch to "main"? |
I didn't touch this PR. The PR was likely closed when the master branch was renamed to main, because the original branch no longer exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36003