Skip to content

Fix doctrees dir of gettext builder #122997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

rffontenelle
Copy link
Contributor

@rffontenelle rffontenelle commented Aug 14, 2024

The single quote around -d build/doctrees-gettext causes Sphinx to consider as the ' build' first directory instead of 'build'. Let's keep all builders' output inside 'build' directory.

@picnixz picnixz added docs Documentation in the Doc dir skip issue skip news labels Aug 14, 2024
@picnixz picnixz requested a review from AA-Turner August 14, 2024 08:07
@AA-Turner AA-Turner merged commit 315a933 into python:main Aug 14, 2024
28 checks passed
@rffontenelle
Copy link
Contributor Author

Can we have backport to 3.13 and 3.12?

blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@rffontenelle
Copy link
Contributor Author

@AA-Turner Can we have this backported to 3.13 and 3.12?

@AA-Turner AA-Turner added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Sep 23, 2024
@miss-islington-app
Copy link

Thanks @rffontenelle for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @rffontenelle for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 23, 2024
(cherry picked from commit 315a933)

Co-authored-by: Rafael Fontenelle <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 23, 2024

GH-124338 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 23, 2024
(cherry picked from commit 315a933)

Co-authored-by: Rafael Fontenelle <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 23, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 23, 2024

GH-124339 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Sep 23, 2024
@AA-Turner
Copy link
Member

Thank you for the reminder @rffontenelle

A

AA-Turner pushed a commit that referenced this pull request Sep 23, 2024
…24339)

Fix doctrees directory for the gettext builder (GH-122997)
(cherry picked from commit 315a933)

Co-authored-by: Rafael Fontenelle <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 23, 2024
…24338)

Fix doctrees directory for the gettext builder (GH-122997)
(cherry picked from commit 315a933)

Co-authored-by: Rafael Fontenelle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants