GH-128469: Revert "warn when libpython was loaded from outside the build directory (#128645)" #129506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the build directory (python#128645)" This reverts commit 29b3ce8.
FFY00
approved these changes
Jan 31, 2025
|
No problem, take your time! Thank you for looking into it. |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
…the build directory (python#128645)" (python#129506)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 29b3ce8.
The new test fails on several Tier-1 buildbots. Per PEP-11, “any breakage should be fixed or reverted immediately”. It's important to keep the tests passing so that we can use them to detect other issues.
I hope the issue can be fixed again soon. Please send a new PR, and add the
test-with-buildbotslabel to check ahead of time.libpythonbeing loaded #128469