Skip to content

Replace non-breaking spaces with normal spaces #130116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

aisk
Copy link
Member

@aisk aisk commented Feb 14, 2025

When reading the documents, I found that a Markdown marker was not rendered correctly by GitHub. I discovered that this was caused by a non-breaking space (\xa0):

case

There are some more non-breaking spaces in the codebase, so I just changed them as well.


📚 Documentation preview 📚: https://cpython-previews--130116.org.readthedocs.build/

@aisk aisk changed the title Using normal spaces to replace non-breaking spaces Replace non-breaking spaces with normal spaces Feb 14, 2025
@aisk aisk added docs Documentation in the Doc dir skip issue skip news labels Feb 14, 2025
@mhsmith
Copy link
Member

mhsmith commented Feb 14, 2025

Most of these probably happened by accidentally pressing option+space on macOS, or similar things on other platforms.

@kumaraditya303 kumaraditya303 removed their request for review February 15, 2025 07:24
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes all make sense to me (in that that they seem to be no-ops and almost certainly accidental typos); my only cause for concern are the changes to historical change notes. I don't think that's a problem, but I'm not 100% sure. I'll confirm with docs maintainers.

Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed there's no issue with updating historical release notes, so this is good to merge. I'll also mark it for backport to 3.13. Thanks for the PR!

@freakboy3742 freakboy3742 added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 16, 2025
@freakboy3742 freakboy3742 merged commit 798f8d3 into python:main Feb 16, 2025
59 checks passed
@miss-islington-app
Copy link

Thanks @aisk for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @aisk and @freakboy3742, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 798f8d3ea9f54ee80a684bff74f67ee7d99e35c2 3.13

@miss-islington-app
Copy link

Sorry, @aisk and @freakboy3742, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 798f8d3ea9f54ee80a684bff74f67ee7d99e35c2 3.12

@freakboy3742
Copy link
Contributor

Looks like the backport isn't trivial; since it isn't essential these fixes are backported, I'll leave them as main-only.

@aisk aisk deleted the remove-nbsp branch February 16, 2025 03:49
@terryjreedy terryjreedy removed needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Feb 18, 2025
@terryjreedy
Copy link
Member

Try to remember to remove backport labels when deciding not needed ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants