gh-133551: Support t-strings in annotationlib #133553

JelleZijlstra · 2025-05-07T05:57:08Z

I don't know why you'd use t-strings in annotations, but now if you do,
the STRING format will do a great job of recovering the source code.

Issue: t-strings in the annotation STRING format #133551

I don't know why you'd use t-strings in annotations, but now if you do, the STRING format will do a great job of recovering the source code.

Lib/annotationlib.py

Lib/test/.ruff.toml

Lib/test/test_annotationlib.py

lysnikolaou

Apart from @AA-Turner's comments, content looks good!

Lib/annotationlib.py

Co-authored-by: Adam Turner <[email protected]>

miss-islington-app · 2025-05-08T01:10:38Z

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

I don't know why you'd use t-strings in annotations, but now if you do, the STRING format will do a great job of recovering the source code. (cherry picked from commit 90f476e) Co-authored-by: Jelle Zijlstra <[email protected]>

bedevere-app · 2025-05-08T01:10:51Z

GH-133628 is a backport of this pull request to the 3.14 branch.

bedevere-bot · 2025-05-08T01:18:54Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 CentOS9 NoGIL 3.x (tier-1) has failed when building commit 90f476e.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1609/builds/2517) and take a look at the build logs.
Check if the failure is related to this commit (90f476e) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1609/builds/2517

Failed tests:

test_unparse

Failed subtests:

test_files - test.test_unparse.DirectoryTestCase.test_files

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.itamaro-centos-aws.nogil/build/Lib/test/test_unparse.py", line 139, in check_ast_roundtrip
    self.assertASTEqual(ast1, ast2)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.itamaro-centos-aws.nogil/build/Lib/test/support/ast_helper.py", line 46, in assertASTEqual
    traverse_compare(ast1, ast2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.itamaro-centos-aws.nogil/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.itamaro-centos-aws.nogil/build/Lib/test/support/ast_helper.py", line 31, in traverse_compare
    traverse_compare(node1, node2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.itamaro-centos-aws.nogil/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.itamaro-centos-aws.nogil/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.itamaro-centos-aws.nogil/build/Lib/test/support/ast_helper.py", line 43, in traverse_compare
    raise self.failureException(msg) from None
AssertionError: First list contains 1 additional elements.

bedevere-bot · 2025-05-08T01:22:50Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.x (tier-2) has failed when building commit 90f476e.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/725/builds/10855) and take a look at the build logs.
Check if the failure is related to this commit (90f476e) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/725/builds/10855

Failed tests:

test_unparse
test_ssl

Failed subtests:

test_files - test.test_unparse.DirectoryTestCase.test_files
test_preauth_data_to_tls_server - test.test_ssl.TestPreHandshakeClose.test_preauth_data_to_tls_server

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/User
s/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_unparse.py", line 139, in check_ast_roundtrip
    self.assertASTEqual(ast1, ast2)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 46, in assertASTEqual
    traverse_compare(ast1, ast2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 31, in traverse_compare
    traverse_compare(node1, node2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 43, in traverse_compare
    raise self.failureException(msg) from None
AssertionError: First list contains 1 additional elements.


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_unparse.py", line 139, in check_ast_roundtrip
    self.assertASTEqual(ast1, ast2)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 46, in assertASTEqual
    traverse_compare(ast1, ast2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 31, in traverse_compare
    traverse_compare(node1, node2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 43, in traverse_compare
    raise self.failureException(msg) from None
AssertionError: First list contains 1 additional elements.


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.x.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_ssl.py", line 5134, in test_preauth_data_to_tls_server
    self.assertIn("before TLS handshake with data", wrap_error.args[1])
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'before TLS handshake with data' not found in '[SSL: RECORD_LAYER_FAILURE] record layer failure (_ssl.c:1077)'

bedevere-bot · 2025-05-08T01:25:42Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Debian Non-Debug with X 3.x (no tier) has failed when building commit 90f476e.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1245/builds/5365) and take a look at the build logs.
Check if the failure is related to this commit (90f476e) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1245/builds/5365

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/test_annotationlib.py"�[0m, line �[35m387�[0m, in �[35mtest_displays�[0m
    �[31mself.assertEqual�[0m�[1;31m(�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^�[0m
        �[1;31manno,�[0m
        �[1;31m^^^^^�[0m
    ...<5 lines>...
        �[1;31m},�[0m
        �[1;31m^^�[0m
    �[1;31m)�[0m
    �[1;31m^�[0m
�[1;35mAssertionError�[0m: �[35m{'w':[29 chars] 'a[{str, int}, 3]', 'y': 'a[{int: str}, 4]', [19 chars] 5]'} != {'w':[29 chars] 'a[{int, str}, 3]', 'y': 'a[{int: str}, 4]', [19 chars] 5]'}
  {'w': 'a[[int, str], float]',
-  'x': 'a[{str, int}, 3]',
?              -----


Traceback (most recent call last):
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/test_unparse.py"�[0m, line �[35m139�[0m, in �[35mcheck_ast_roundtrip�[0m
    �[31mself.assertASTEqual�[0m�[1;31m(ast1, ast2)�[0m
    �[31m~~~~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/support/ast_helper.py"�[0m, line �[35m46�[0m, in �[35massertASTEqual�[0m
    �[31mtraverse_compare�[0m�[1;31m(ast1, ast2)�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/support/ast_helper.py"�[0m, line �[35m27�[0m, in �[35mtraverse_compare�[0m
    �[31mtraverse_compare�[0m�[1;31m(value1, value2)�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/support/ast_helper.py"�[0m, line �[35m31�[0m, in �[35mtraverse_compare�[0m
    �[31mtraverse_compare�[0m�[1;31m(node1, node2)�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/support/ast_helper.py"�[0m, line �[35m27�[0m, in �[35mtraverse_compare�[0m
    �[31mtraverse_compare�[0m�[1;31m(value1, value2)�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/support/ast_helper.py"�[0m, line �[35m27�[0m, in �[35mtraverse_compare�[0m
    �[31mtraverse_compare�[0m�[1;31m(value1, value2)�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/support/ast_helper.py"�[0m, line �[35m43�[0m, in �[35mtraverse_compare�[0m
    raise self.failureException(msg) from None
�[1;35mAssertionError�[0m: �[35mFirst list contains 1 additional elements.�[0m

bedevere-bot · 2025-05-08T01:26:17Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD14 3.x (tier-3) has failed when building commit 90f476e.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1232/builds/5706) and take a look at the build logs.
Check if the failure is related to this commit (90f476e) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1232/builds/5706

Failed tests:

test_unparse

Failed subtests:

test_files - test.test_unparse.DirectoryTestCase.test_files

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/test_unparse.py", line 139, in check_ast_roundtrip
    self.assertASTEqual(ast1, ast2)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/support/ast_helper.py", line 46, in assertASTEqual
    traverse_compare(ast1, ast2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/support/ast_helper.py", line 31, in traverse_compare
    traverse_compare(node1, node2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.x.opsec-fbsd14/build/Lib/test/support/ast_helper.py", line 43, in traverse_compare
    raise self.failureException(msg) from None
AssertionError: First list contains 1 additional elements.

bedevere-bot · 2025-05-08T01:28:05Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows Server 2022 NoGIL 3.x (tier-1) has failed when building commit 90f476e.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1241/builds/5660) and take a look at the build logs.
Check if the failure is related to this commit (90f476e) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1241/builds/5660

Failed tests:

test_unparse
test.test_multiprocessing_spawn.test_misc

Failed subtests:

test_wait_integer - test.test_multiprocessing_spawn.test_misc.TestWait.test_wait_integer

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_unparse.py", line 139, in check_ast_roundtrip
    self.assertASTEqual(ast1, ast2)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\support\ast_helper.py", line 46, in assertASTEqual
    traverse_compare(ast1, ast2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\support\ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\support\ast_helper.py", line 31, in traverse_compare
    traverse_compare(node1, node2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\support\ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\support\ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\support\ast_helper.py", line 43, in traverse_compare
    raise self.failureException(msg) from None
AssertionError: First list contains 1 additional elements.


Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\_test_multiprocessing.py", line 5470, in test_wait_integer
    self.assertLess(delta, expected + 2)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
AssertionError: 9.269663200015202 not less than 5

bedevere-bot · 2025-05-08T01:28:56Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x (tier-1) has failed when building commit 90f476e.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/345/builds/11274) and take a look at the build logs.
Check if the failure is related to this commit (90f476e) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/345/builds/11274

Failed tests:

test_unparse

Failed subtests:

test_files - test.test_unparse.DirectoryTestCase.test_files

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test_unparse.py", line 139, in check_ast_roundtrip
    self.assertASTEqual(ast1, ast2)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/ast_helper.py", line 46, in assertASTEqual
    traverse_compare(ast1, ast2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/ast_helper.py", line 31, in traverse_compare
    traverse_compare(node1, node2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/ast_helper.py", line 43, in traverse_compare
    raise self.failureException(msg) from None
AssertionError: First list contains 1 additional elements.

bedevere-bot · 2025-05-08T01:30:26Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Android 3.x (tier-3) has failed when building commit 90f476e.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1594/builds/2298) and take a look at the build logs.
Check if the failure is related to this commit (90f476e) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1594/builds/2298

Failed tests:

test_unparse

Failed subtests:

test_files - test.test_unparse.DirectoryTestCase.test_files

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.15/test/test_unparse.py", line 139, in check_ast_roundtrip
    self.assertASTEqual(ast1, ast2)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/data/user/0/org.python.testbed/files/python/lib/python3.15/test/support/ast_helper.py", line 46, in assertASTEqual
    traverse_compare(ast1, ast2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/data/user/0/org.python.testbed/files/python/lib/python3.15/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/data/user/0/org.python.testbed/files/python/lib/python3.15/test/support/ast_helper.py", line 31, in traverse_compare
    traverse_compare(node1, node2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/data/user/0/org.python.testbed/files/python/lib/python3.15/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/data/user/0/org.python.testbed/files/python/lib/python3.15/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/data/user/0/org.python.testbed/files/python/lib/python3.15/test/support/ast_helper.py", line 43, in traverse_compare
    raise self.failureException(msg) from None
AssertionError: First list contains 1 additional elements.

…3628) gh-133551: Support t-strings in annotationlib (GH-133553) I don't know why you'd use t-strings in annotations, but now if you do, the STRING format will do a great job of recovering the source code. (cherry picked from commit 90f476e) Co-authored-by: Jelle Zijlstra <[email protected]>

bedevere-bot · 2025-05-08T01:43:43Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 CentOS9 NoGIL 3.14 (tier-1) has failed when building commit 9e1aa35.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1733/builds/4) and take a look at the build logs.
Check if the failure is related to this commit (9e1aa35) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1733/builds/4

Failed tests:

test_unparse

Failed subtests:

test_files - test.test_unparse.DirectoryTestCase.test_files

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.itamaro-centos-aws.nogil/build/Lib/test/test_unparse.py", line 139, in check_ast_roundtrip
    self.assertASTEqual(ast1, ast2)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.itamaro-centos-aws.nogil/build/Lib/test/support/ast_helper.py", line 46, in assertASTEqual
    traverse_compare(ast1, ast2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.itamaro-centos-aws.nogil/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.itamaro-centos-aws.nogil/build/Lib/test/support/ast_helper.py", line 31, in traverse_compare
    traverse_compare(node1, node2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.itamaro-centos-aws.nogil/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.itamaro-centos-aws.nogil/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.itamaro-centos-aws.nogil/build/Lib/test/support/ast_helper.py", line 43, in traverse_compare
    raise self.failureException(msg) from None
AssertionError: First list contains 1 additional elements.

bedevere-bot · 2025-05-08T01:50:36Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Debian Installed with X 3.14 (no tier) has failed when building commit 9e1aa35.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1793/builds/4) and take a look at the build logs.
Check if the failure is related to this commit (9e1aa35) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1793/builds/4

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.installed/build/target/lib/python3.14/test/test_unparse.py"�[0m, line �[35m139�[0m, in �[35mcheck_ast_roundtrip�[0m
    �[31mself.assertASTEqual�[0m�[1;31m(ast1, ast2)�[0m
    �[31m~~~~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.installed/build/target/lib/python3.14/test/support/ast_helper.py"�[0m, line �[35m46�[0m, in �[35massertASTEqual�[0m
    �[31mtraverse_compare�[0m�[1;31m(ast1, ast2)�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.installed/build/target/lib/python3.14/test/support/ast_helper.py"�[0m, line �[35m27�[0m, in �[35mtraverse_compare�[0m
    �[31mtraverse_compare�[0m�[1;31m(value1, value2)�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.installed/build/target/lib/python3.14/test/support/ast_helper.py"�[0m, line �[35m31�[0m, in �[35mtraverse_compare�[0m
    �[31mtraverse_compare�[0m�[1;31m(node1, node2)�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.installed/build/target/lib/python3.14/test/support/ast_helper.py"�[0m, line �[35m27�[0m, in �[35mtraverse_compare�[0m
    �[31mtraverse_compare�[0m�[1;31m(value1, value2)�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.installed/build/target/lib/python3.14/test/support/ast_helper.py"�[0m, line �[35m27�[0m, in �[35mtraverse_compare�[0m
    �[31mtraverse_compare�[0m�[1;31m(value1, value2)�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.installed/build/target/lib/python3.14/test/support/ast_helper.py"�[0m, line �[35m43�[0m, in �[35mtraverse_compare�[0m
    raise self.failureException(msg) from None
�[1;35mAssertionError�[0m: �[35mFirst list contains 1 additional elements.�[0m

bedevere-bot · 2025-05-08T01:50:49Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 macOS 3.14 (tier-2) has failed when building commit 9e1aa35.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1772/builds/4) and take a look at the build logs.
Check if the failure is related to this commit (9e1aa35) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1772/builds/4

Failed tests:

test_unparse

Failed subtests:

test_files - test.test_unparse.DirectoryTestCase.test_files

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/test_unparse.py", line 139, in check_ast_roundtrip
    self.assertASTEqual(ast1, ast2)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 46, in assertASTEqual
    traverse_compare(ast1, ast2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 31, in traverse_compare
    traverse_compare(node1, node2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/buildarea/3.14.pablogsal-macos-m1.macos-with-brew/build/Lib/test/support/ast_helper.py", line 43, in traverse_compare
    raise self.failureException(msg) from None
AssertionError: First list contains 1 additional elements.

bedevere-bot · 2025-05-08T01:51:07Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 MacOS M1 NoGIL 3.14 (tier-2) has failed when building commit 9e1aa35.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1680/builds/4) and take a look at the build logs.
Check if the failure is related to this commit (9e1aa35) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1680/builds/4

Failed tests:

test_unparse

Failed subtests:

test_files - test.test_unparse.DirectoryTestCase.test_files

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/ec2-user/buildbot/buildarea/3.14.itamaro-macos-arm64-aws.macos-with-brew.nogil/build/Lib/test/test_unparse.py", line 139, in check_ast_roundtrip
    self.assertASTEqual(ast1, ast2)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/Users/ec2-user/buildbot/buildarea/3.14.itamaro-macos-arm64-aws.macos-with-brew.nogil/build/Lib/test/support/ast_helper.py", line 46, in assertASTEqual
    traverse_compare(ast1, ast2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/Users/ec2-user/buildbot/buildarea/3.14.itamaro-macos-arm64-aws.macos-with-brew.nogil/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/ec2-user/buildbot/buildarea/3.14.itamaro-macos-arm64-aws.macos-with-brew.nogil/build/Lib/test/support/ast_helper.py", line 31, in traverse_compare
    traverse_compare(node1, node2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/Users/ec2-user/buildbot/buildarea/3.14.itamaro-macos-arm64-aws.macos-with-brew.nogil/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/ec2-user/buildbot/buildarea/3.14.itamaro-macos-arm64-aws.macos-with-brew.nogil/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/ec2-user/buildbot/buildarea/3.14.itamaro-macos-arm64-aws.macos-with-brew.nogil/build/Lib/test/support/ast_helper.py", line 43, in traverse_compare
    raise self.failureException(msg) from None
AssertionError: First list contains 1 additional elements.

bedevere-bot · 2025-05-08T01:57:58Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Debian Non-Debug with X 3.14 (no tier) has failed when building commit 9e1aa35.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1687/builds/4) and take a look at the build logs.
Check if the failure is related to this commit (9e1aa35) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1687/builds/4

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.nondebug/build/Lib/test/test_unparse.py"�[0m, line �[35m139�[0m, in �[35mcheck_ast_roundtrip�[0m
    �[31mself.assertASTEqual�[0m�[1;31m(ast1, ast2)�[0m
    �[31m~~~~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.nondebug/build/Lib/test/support/ast_helper.py"�[0m, line �[35m46�[0m, in �[35massertASTEqual�[0m
    �[31mtraverse_compare�[0m�[1;31m(ast1, ast2)�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.nondebug/build/Lib/test/support/ast_helper.py"�[0m, line �[35m27�[0m, in �[35mtraverse_compare�[0m
    �[31mtraverse_compare�[0m�[1;31m(value1, value2)�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.nondebug/build/Lib/test/support/ast_helper.py"�[0m, line �[35m31�[0m, in �[35mtraverse_compare�[0m
    �[31mtraverse_compare�[0m�[1;31m(node1, node2)�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.nondebug/build/Lib/test/support/ast_helper.py"�[0m, line �[35m27�[0m, in �[35mtraverse_compare�[0m
    �[31mtraverse_compare�[0m�[1;31m(value1, value2)�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.nondebug/build/Lib/test/support/ast_helper.py"�[0m, line �[35m27�[0m, in �[35mtraverse_compare�[0m
    �[31mtraverse_compare�[0m�[1;31m(value1, value2)�[0m
    �[31m~~~~~~~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.14.ware-debian-x86.nondebug/build/Lib/test/support/ast_helper.py"�[0m, line �[35m43�[0m, in �[35mtraverse_compare�[0m
    raise self.failureException(msg) from None
�[1;35mAssertionError�[0m: �[35mFirst list contains 1 additional elements.�[0m

bedevere-bot · 2025-05-08T01:59:22Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD14 3.14 (tier-3) has failed when building commit 9e1aa35.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1740/builds/4) and take a look at the build logs.
Check if the failure is related to this commit (9e1aa35) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1740/builds/4

Failed tests:

test_unparse

Failed subtests:

test_files - test.test_unparse.DirectoryTestCase.test_files

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.14.opsec-fbsd14/build/Lib/test/test_unparse.py", line 139, in check_ast_roundtrip
    self.assertASTEqual(ast1, ast2)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.opsec-fbsd14/build/Lib/test/support/ast_helper.py", line 46, in assertASTEqual
    traverse_compare(ast1, ast2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.opsec-fbsd14/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.opsec-fbsd14/build/Lib/test/support/ast_helper.py", line 31, in traverse_compare
    traverse_compare(node1, node2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.opsec-fbsd14/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.opsec-fbsd14/build/Lib/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/home/buildbot/buildarea/3.14.opsec-fbsd14/build/Lib/test/support/ast_helper.py", line 43, in traverse_compare
    raise self.failureException(msg) from None
AssertionError: First list contains 1 additional elements.

bedevere-bot · 2025-05-08T02:02:37Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows Server 2022 NoGIL 3.14 (tier-1) has failed when building commit 9e1aa35.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1717/builds/4) and take a look at the build logs.
Check if the failure is related to this commit (9e1aa35) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1717/builds/4

Failed tests:

test_unparse

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.14.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\test_unparse.py", line 139, in check_ast_roundtrip
    self.assertASTEqual(ast1, ast2)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.14.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\support\ast_helper.py", line 46, in assertASTEqual
    traverse_compare(ast1, ast2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.14.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\support\ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.14.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\support\ast_helper.py", line 31, in traverse_compare
    traverse_compare(node1, node2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.14.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\support\ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.14.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\support\ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "C:\Users\Administrator\buildarea\3.14.itamaro-win64-srv-22-aws.x64.nogil\build\Lib\test\support\ast_helper.py", line 43, in traverse_compare
    raise self.failureException(msg) from None
AssertionError: First list contains 1 additional elements.

bedevere-bot · 2025-05-08T02:05:25Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.x (tier-3) has failed when building commit 90f476e.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1380/builds/3609) and take a look at the build logs.
Check if the failure is related to this commit (90f476e) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1380/builds/3609

Failed tests:

test_unparse

Failed subtests:

test_files - test.test_unparse.DirectoryTestCase.test_files

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/0084C28A-2B78-4724-BF02-BF99CCD71A3E/data/Containers/Bundle/Application/AA65B0AA-06AE-4D26-9B0A-47AC0BB74630/iOSTestbed.app/python/lib/python3.15/test/test_unparse.py", line 139, in check_ast_roundtrip
    self.assertASTEqual(ast1, ast2)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/0084C28A-2B78-4724-BF02-BF99CCD71A3E/data/Containers/Bundle/Application/AA65B0AA-06AE-4D26-9B0A-47AC0BB74630/iOSTestbed.app/python/lib/python3.15/test/support/ast_helper.py", line 46, in assertASTEqual
    traverse_compare(ast1, ast2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/0084C28A-2B78-4724-BF02-BF99CCD71A3E/data/Containers/Bundle/Application/AA65B0AA-06AE-4D26-9B0A-47AC0BB74630/iOSTestbed.app/python/lib/python3.15/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/0084C28A-2B78-4724-BF02-BF99CCD71A3E/data/Containers/Bundle/Application/AA65B0AA-06AE-4D26-9B0A-47AC0BB74630/iOSTestbed.app/python/lib/python3.15/test/support/ast_helper.py", line 31, in traverse_compare
    traverse_compare(node1, node2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/0084C28A-2B78-4724-BF02-BF99CCD71A3E/data/Containers/Bundle/Application/AA65B0AA-06AE-4D26-9B0A-47AC0BB74630/iOSTestbed.app/python/lib/python3.15/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/0084C28A-2B78-4724-BF02-BF99CCD71A3E/data/Containers/Bundle/Application/AA65B0AA-06AE-4D26-9B0A-47AC0BB74630/iOSTestbed.app/python/lib/python3.15/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/0084C28A-2B78-4724-BF02-BF99CCD71A3E/data/Containers/Bundle/Application/AA65B0AA-06AE-4D26-9B0A-47AC0BB74630/iOSTestbed.app/python/lib/python3.15/test/support/ast_helper.py", line 43, in traverse_compare
    raise self.failureException(msg) from None
AssertionError: First list contains 1 additional elements.

bedevere-bot · 2025-05-08T02:19:06Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Android 3.14 (tier-3) has failed when building commit 9e1aa35.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1794/builds/4) and take a look at the build logs.
Check if the failure is related to this commit (9e1aa35) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1794/builds/4

Failed tests:

test_unparse

Failed subtests:

test_files - test.test_unparse.DirectoryTestCase.test_files

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_unparse.py", line 139, in check_ast_roundtrip
    self.assertASTEqual(ast1, ast2)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/support/ast_helper.py", line 46, in assertASTEqual
    traverse_compare(ast1, ast2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/support/ast_helper.py", line 31, in traverse_compare
    traverse_compare(node1, node2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/support/ast_helper.py", line 43, in traverse_compare
    raise self.failureException(msg) from None
AssertionError: First list contains 1 additional elements.

bedevere-bot · 2025-05-08T02:36:18Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot iOS ARM64 Simulator 3.14 (tier-3) has failed when building commit 9e1aa35.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1722/builds/4) and take a look at the build logs.
Check if the failure is related to this commit (9e1aa35) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1722/builds/4

Failed tests:

test_unparse

Failed subtests:

test_files - test.test_unparse.DirectoryTestCase.test_files

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/Library/Developer/XCTestDevices/047C7520-C084-482C-B9E5-75522E673869/data/Containers/Bundle/Application/D82F22A3-CFCA-4729-A81B-61777EBF18D5/iOSTestbed.app/python/lib/python3.14/test/test_unparse.py", line 139, in check_ast_roundtrip
    self.assertASTEqual(ast1, ast2)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/047C7520-C084-482C-B9E5-75522E673869/data/Containers/Bundle/Application/D82F22A3-CFCA-4729-A81B-61777EBF18D5/iOSTestbed.app/python/lib/python3.14/test/support/ast_helper.py", line 46, in assertASTEqual
    traverse_compare(ast1, ast2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/047C7520-C084-482C-B9E5-75522E673869/data/Containers/Bundle/Application/D82F22A3-CFCA-4729-A81B-61777EBF18D5/iOSTestbed.app/python/lib/python3.14/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/047C7520-C084-482C-B9E5-75522E673869/data/Containers/Bundle/Application/D82F22A3-CFCA-4729-A81B-61777EBF18D5/iOSTestbed.app/python/lib/python3.14/test/support/ast_helper.py", line 31, in traverse_compare
    traverse_compare(node1, node2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/047C7520-C084-482C-B9E5-75522E673869/data/Containers/Bundle/Application/D82F22A3-CFCA-4729-A81B-61777EBF18D5/iOSTestbed.app/python/lib/python3.14/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/047C7520-C084-482C-B9E5-75522E673869/data/Containers/Bundle/Application/D82F22A3-CFCA-4729-A81B-61777EBF18D5/iOSTestbed.app/python/lib/python3.14/test/support/ast_helper.py", line 27, in traverse_compare
    traverse_compare(value1, value2)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "/Users/buildbot/Library/Developer/XCTestDevices/047C7520-C084-482C-B9E5-75522E673869/data/Containers/Bundle/Application/D82F22A3-CFCA-4729-A81B-61777EBF18D5/iOSTestbed.app/python/lib/python3.14/test/support/ast_helper.py", line 43, in traverse_compare
    raise self.failureException(msg) from None
AssertionError: First list contains 1 additional elements.

I don't know why you'd use t-strings in annotations, but now if you do, the STRING format will do a great job of recovering the source code.

pythongh-133551: Support t-strings in annotationlib

1cfdd2d

I don't know why you'd use t-strings in annotations, but now if you do, the STRING format will do a great job of recovering the source code.

JelleZijlstra requested a review from lysnikolaou May 7, 2025 05:57

JelleZijlstra requested review from hugovk, AlexWaygood and AA-Turner as code owners May 7, 2025 05:57

bedevere-app bot mentioned this pull request May 7, 2025

t-strings in the annotation STRING format #133551

Closed

bedevere-app bot added the awaiting core review label May 7, 2025

AA-Turner reviewed May 7, 2025

View reviewed changes

Lib/annotationlib.py Outdated Show resolved Hide resolved

Lib/annotationlib.py Outdated Show resolved Hide resolved

Lib/test/.ruff.toml Outdated Show resolved Hide resolved

Lib/test/test_annotationlib.py Outdated Show resolved Hide resolved

lysnikolaou approved these changes May 7, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting core review labels May 7, 2025

JelleZijlstra commented May 7, 2025

View reviewed changes

Lib/annotationlib.py Outdated Show resolved Hide resolved

JelleZijlstra and others added 3 commits May 7, 2025 06:35

Apply suggestions from code review

242387c

Co-authored-by: Adam Turner <[email protected]>

fix warning, one more test

84bc5b4

line length

c1c1800

AlexWaygood removed their request for review May 7, 2025 14:47

JelleZijlstra mentioned this pull request May 7, 2025

t-strings: AST unparsing does not reproduce original formatting #133581

Closed

AA-Turner approved these changes May 8, 2025

View reviewed changes

JelleZijlstra added the needs backport to 3.14 bugs and security fixes label May 8, 2025

JelleZijlstra merged commit 90f476e into python:main May 8, 2025
41 checks passed

bedevere-app bot removed the awaiting merge label May 8, 2025

JelleZijlstra deleted the 749-750 branch May 8, 2025 01:10

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 8, 2025

Uh oh!

gh-133551: Support t-strings in annotationlib #133553

gh-133551: Support t-strings in annotationlib #133553

Uh oh!

Conversation

JelleZijlstra commented May 7, 2025 • edited by bedevere-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lysnikolaou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

miss-islington-app bot commented May 8, 2025

Uh oh!

bedevere-app bot commented May 8, 2025

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented May 8, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Uh oh!

JelleZijlstra commented May 7, 2025 •

edited by bedevere-app bot

Loading