Skip to content

gh-134861: Add CSV and 🍌SV output formats to asyncio ps #134862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

gh-134861: Add CSV and 🍌SV output formats to asyncio ps #134862

wants to merge 8 commits into from
+52 −3

Conversation

dpdani
Copy link
Contributor

@dpdani dpdani commented May 28, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 28, 2025
Open
@dpdani
Merge branch 'main' into feature/pending-tasks-csv-bsv
75d0b14 
# Conflicts:
#	Lib/asyncio/tools.py
@ZeroIntensity
Copy link
Member

(Skipping news because this is an easter egg)

@johnzhou721
Copy link
Contributor

@ZeroIntensity Hmm... But isn't the CSV format legit, so in my (very bad) opinion it still need news?

@ZeroIntensity
Copy link
Member

Oh, hm. I guess we could add an entry for only CSV. I'll leave the decision to @dpdani.

AA-Turner
AA-Turner reviewed May 29, 2025
View reviewed changes
@AA-Turner
Copy link
Member

@ZeroIntensity Hmm... But isn't the CSV format legit, so in my (very bad) opinion it still need news?

Yes, please add news for CSV format

johnzhou721
johnzhou721 suggested changes May 29, 2025
View reviewed changes
Copy link
Contributor

@johnzhou721 johnzhou721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, agreed with the NEWS part. But might it make the Easter Egg too obvious? Since people can just look at the PR through news. I think we might be able to split up the PRs into CSV and BSV and skip news on the latter, but it might be too much work.

johnzhou721
johnzhou721 reviewed May 29, 2025
View reviewed changes
johnzhou721
johnzhou721 reviewed May 29, 2025
View reviewed changes
nineteendo
nineteendo reviewed May 29, 2025
View reviewed changes
@AA-Turner
Copy link
Member

AA-Turner commented May 29, 2025 •
edited
Loading

Yep, agreed with the NEWS part. But might it make the Easter Egg too obvious? Since people can just look at the PR through news. I think we might be able to split up the PRs into CSV and BSV and skip news on the latter, but it might be too much work.

We're not trying to hide or obsfucate; just not to advertise.

danielhollas
danielhollas reviewed May 29, 2025
View reviewed changes
@dpdani @AA-Turner
Update Lib/asyncio/tools.py
4b77995 
Co-authored-by: Adam Turner <[email protected]>
@python-cla-bot
Copy link

python-cla-bot bot commented May 29, 2025 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@johnzhou721
Copy link
Contributor

johnzhou721 commented May 29, 2025 via email

johnzhou721

This comment was marked as outdated.

Sign in to view

@dpdani
Merge branch 'main' into feature/pending-tasks-csv-bsv
fe3cf6c 
# Conflicts:
#	Lib/asyncio/tools.py
johnzhou721
johnzhou721 reviewed Jun 20, 2025
View reviewed changes
Lib/asyncio/tools.py
@@ -264,7 +264,7 @@ def display_awaited_by_tasks_table(
def _display_awaited_by_tasks_table(table) -> None:
# Print the table in a simple tabular format
print(
f"{_header[0]:<10} {_header[1]:<20} {_header[2]:<20} {_header[3]:<50} {_header[4]:<20} {_header[5]:<15}"
f"{_header[0]:<10} {_header[1]:<20} {_header[2]:<20} {_header[3]:<50} {_header[4]:<50} {_header[5]:<15} {_header[6]:<15}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try storing the numbers in either another array or a tulle with headers and for loop this print.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AA-Turner AA-Turner AA-Turner left review comments

@danielhollas danielhollas danielhollas left review comments

@nineteendo nineteendo nineteendo left review comments

@johnzhou721 johnzhou721 johnzhou721 approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees
No one assigned
Labels
awaiting core review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dpdani @ZeroIntensity @johnzhou721 @AA-Turner @danielhollas @nineteendo