[3.6] Doc: Add an optional obsolete header. (GH-13638). #13657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 46ed90d) Co-authored-by: Julien Palard <[email protected]>
|
@ned-deily Hi Ned, would you please merge this, if you like it? See screenshot here: #13638 |
ned-deily
requested changes
May 30, 2019
Doc/tools/templates/layout.html
Outdated
| <div id="outdated-warning" style="padding: .5em; text-align: center; background-color: #FFBABA; color: #6A0E0E;"> | ||
| {% trans %}This document is for an old version of Python that is no longer supported. | ||
| You should upgrade, and read the {% endtrans %} | ||
| <a href="/3/{{ pagename }}{{ file_suffix }}">{% trans %} Python documentation for the last stable release {% endtrans %}</a>. |
There was a problem hiding this comment.
Suggest using "most recent" or "current" rather than "last" to avoid ambiguity ("most recent" vs "final").
|
When you're done making the requested changes, leave the comment: |
I think I'll add it thrue docsbuild-scripts, not via the file, so for future releases I won't have to commit the boolean to conf.py. |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @ned-deily: please review the changes made to this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 46ed90d)
Co-authored-by: Julien Palard [email protected]