Skip to content

bpo-37069: regrtest: unraisable marks test as ENV_CHANGED #13759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2019
Merged

bpo-37069: regrtest: unraisable marks test as ENV_CHANGED #13759

merged 1 commit into from
Jun 12, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jun 2, 2019

If a test emits at least one unraisable exception, the test is marked
as "environment altered" (ENV_CHANGED).

https://bugs.python.org/issue37069

@vstinner vstinner changed the title [WIP] bpo-37069: regrtest: unraisable marks test as ENV_CHANGED bpo-37069: regrtest: unraisable marks test as ENV_CHANGED Jun 12, 2019
regrtest now uses sys.unraisablehook() to mark a test as "environment
altered" (ENV_CHANGED) if it emits an "unraisable exception".
Moreover, regrtest logs a warning in this case.

Use "python3 -m test --fail-env-changed" to catch unraisable
exceptions in tests.
@vstinner vstinner merged commit 95f61c8 into python:master Jun 12, 2019
@vstinner vstinner deleted the unraisable_env_changed branch June 12, 2019 23:11
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
regrtest now uses sys.unraisablehook() to mark a test as "environment
altered" (ENV_CHANGED) if it emits an "unraisable exception".
Moreover, regrtest logs a warning in this case.

Use "python3 -m test --fail-env-changed" to catch unraisable
exceptions in tests.
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
regrtest now uses sys.unraisablehook() to mark a test as "environment
altered" (ENV_CHANGED) if it emits an "unraisable exception".
Moreover, regrtest logs a warning in this case.

Use "python3 -m test --fail-env-changed" to catch unraisable
exceptions in tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants