bpo-22367: Add test_lockf #17010
Merged
bpo-22367: Add test_lockf #17010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corona10
force-pushed
the
bpo-22367-unittest
branch
from
27ebf5e to
a9eb79d
Compare
| @@ -12,7 +12,6 @@ | |||
| fcntl = import_module('fcntl') | |||
|
|
|||
|
|
|||
| # TODO - Write tests for flock() and lockf(). | |||
There was a problem hiding this comment.
Is the part about flock() still relevant?
There was a problem hiding this comment.
https://github.com/python/cpython/blob/master/Lib/test/test_fcntl.py#L127
test_flock already exists.
But if the test is not enough, the comment should be remain
corona10
force-pushed
the
bpo-22367-unittest
branch
from
99a8879 to
4138cba
Compare
|
@serhiy-storchaka |
serhiy-storchaka
approved these changes
Nov 7, 2019
|
Thanks @corona10 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
Thanks @corona10 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-17084 is a backport of this pull request to the 3.8 branch. |
|
GH-17085 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 7, 2019
(cherry picked from commit befa032) Co-authored-by: Dong-hee Na <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Nov 9, 2019
(cherry picked from commit befa032) Co-authored-by: Dong-hee Na <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Nov 9, 2019
(cherry picked from commit befa032) Co-authored-by: Dong-hee Na <[email protected]>
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before working on bpo-22367, I 'd like to add unit test for fcntl.lockf
https://bugs.python.org/issue22367