Skip to content

remove the wrong footnote notation #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2017
Merged

remove the wrong footnote notation #181

merged 1 commit into from
Feb 19, 2017

Conversation

qingpeng
Copy link

extra [1]

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

  1. If you don't have an account on b.p.o, please create one
  2. Make sure your GitHub username is listed in "Your Details" at b.p.o
  3. If you have not already done so, please sign the PSF contributor agreement
  4. If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  5. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

berkerpeksag
berkerpeksag approved these changes Feb 19, 2017
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks. It looks like a merge glitch introduced in cc79837.

@berkerpeksag
Copy link
Member

I'm going to merge this since it's just a typo fix but please follow the steps described in #181 (comment) if you'd like to send more PRs. Thanks!

@berkerpeksag berkerpeksag merged commit 4bfb603 into python:2.7 Feb 19, 2017
akruis pushed a commit to akruis/cpython that referenced this pull request Nov 12, 2018
Stackless issue python#181: Replace slp_dont_optimize... vars
a8cf08d 
by more appropriate compiler specific code. The new code should work
with whole program optimisation.

(cherry picked from commit 464ef17bcbf634ae33b37672a5b803f0ce940086)
akruis pushed a commit to akruis/cpython that referenced this pull request Nov 12, 2018
Stackless issue python#181: Replace slp_dont_optimize... vars
d71003f 
by more appropriate compiler specific code. The new code should work
with whole program optimisation.
akruis pushed a commit to akruis/cpython that referenced this pull request Jan 5, 2019
Stackless issue python#181: remove hacks from ignored global list
b6644c3 
The variables no longer exist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qingpeng @the-knights-who-say-ni @berkerpeksag