Skip to content

bpo-39869: Fix typo in 'Instance objects' section. #18889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2020
Merged

bpo-39869: Fix typo in 'Instance objects' section. #18889

merged 1 commit into from
Mar 10, 2020

Conversation

awecx
Copy link
Contributor

@awecx awecx commented Mar 9, 2020 •
edited by miss-islington
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Mar 9, 2020
eamanu
eamanu approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the news could be skpped

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit e5e5632 into python:master Mar 10, 2020
@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.

@miss-islington
Copy link
Contributor

Thanks @awecx for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @awecx, I had trouble checking out the 3.7 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e5e56328afac50aad6d8893185d8e7ba8928afe2 3.7

@miss-islington miss-islington self-assigned this Mar 10, 2020
@Mariatta
Copy link
Member

Thanks!

@bedevere-bot
Copy link

GH-18898 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2020
@awecx @miss-islington
bpo-39869: Fix typo in 'Instance objects' section. (pythonGH-18889)
46fe9e8 
(cherry picked from commit e5e5632)

Co-authored-by: Antoine <[email protected]>
@miss-islington
Copy link
Contributor

Thanks @awecx for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @awecx for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-18899 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2020
@awecx @miss-islington
bpo-39869: Fix typo in 'Instance objects' section. (pythonGH-18889)
6ee5fe6 
(cherry picked from commit e5e5632)

Co-authored-by: Antoine <[email protected]>
@bedevere-bot
Copy link

GH-18900 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2020
@awecx @miss-islington
bpo-39869: Fix typo in 'Instance objects' section. (pythonGH-18889)
b1bd874 
(cherry picked from commit e5e5632)

Co-authored-by: Antoine <[email protected]>
miss-islington added a commit that referenced this pull request Mar 10, 2020
@miss-islington @awecx
bpo-39869: Fix typo in 'Instance objects' section. (GH-18889)
5b29a82 
(cherry picked from commit e5e5632)

Co-authored-by: Antoine <[email protected]>
miss-islington added a commit that referenced this pull request Mar 14, 2020
@miss-islington @awecx
bpo-39869: Fix typo in 'Instance objects' section. (GH-18889)
4abe77c 
(cherry picked from commit e5e5632)

Co-authored-by: Antoine <[email protected]>
ned-deily pushed a commit that referenced this pull request Mar 14, 2020
@miss-islington @awecx
bpo-39869: Fix typo in 'Instance objects' section. (GH-18889) (GH-18898)
6b6756f 
(cherry picked from commit e5e5632)

Co-authored-by: Antoine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulcd raulcd raulcd approved these changes

@Mariatta Mariatta Mariatta approved these changes

@eamanu eamanu eamanu approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@awecx @miss-islington @Mariatta @bedevere-bot @raulcd @eamanu @the-knights-who-say-ni