Skip to content

bpo-40939: Delete remaining references to Grammar/Grammar #21624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2020

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Jul 26, 2020

I found a few more references to Grammar/Grammar that can be deleted. Including docs for parser and symbol (the modules themselves are already gone.)

(Ironically, Grammar/Grammar itself remains, since it's still referenced from the docs, and we haven't gotten a replacement yet. See we-like-parsers#135.)

https://bugs.python.org/issue40939

(Ironically, the file itself remains, see we-like-parsers#135.)
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gvanrossum
Copy link
Member Author

The failure is a timeout in the asyncio tests on win64. I’m going to merge.

@gvanrossum gvanrossum merged commit 508ed2d into python:master Jul 26, 2020
@bedevere-bot
Copy link

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!

@gvanrossum gvanrossum deleted the delete-grammar-refs branch July 26, 2020 15:28
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 4, 2020
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants