Skip to content

bpo-30722: adjust to new RegexFlags enum, remove LOCALE checkbox #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2017
Merged

bpo-30722: adjust to new RegexFlags enum, remove LOCALE checkbox #2311

merged 2 commits into from
Oct 23, 2017

Conversation

csarn
Copy link
Contributor

@csarn csarn commented Jun 21, 2017 •
edited by bedevere-bot
Loading

@mention-bot
Copy link

@csarn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tim-one, @ned-deily and @vadmium to be potential reviewers.

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@csarn csarn requested a review from a team October 23, 2017 16:48
@csarn csarn requested a review from a team as a code owner October 23, 2017 16:48
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@berkerpeksag
Copy link
Member

Sorry folks, I forgot to rebase the branch before pushing it to contributor's remote.

berkerpeksag
berkerpeksag approved these changes Oct 23, 2017
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thank you! I just added a NEWS entry and will merge it once Travis is done.

@berkerpeksag berkerpeksag merged commit 62adc55 into python:master Oct 23, 2017
@miss-islington
Copy link
Contributor

Thanks @csarn for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-4090 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 23, 2017
@csarn @miss-islington
bpo-30722: Make redemo work with Python 3.6+ (pythonGH-2311)
3abd390 
(cherry picked from commit 62adc55)
berkerpeksag pushed a commit that referenced this pull request Oct 23, 2017
@miss-islington @berkerpeksag
bpo-30722: Make redemo work with Python 3.6+ (GH-2311)
a5f9d24 
(cherry picked from commit 62adc55)
@terryjreedy
Copy link
Member

Thanks for explaining that the review request was not a bug in the bot ;-).

@csarn csarn mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@csarn @mention-bot @the-knights-who-say-ni @berkerpeksag @miss-islington @bedevere-bot @terryjreedy @Mariatta