bpo-42692: fix __builtin_available check on older compilers #23873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A compiler that doesn't define __has_builtin will error out when it is used on the same line as the check for it.
ronaldoussoren
added
needs backport to 3.9
|
@jmroot: Status check is done, and it's a success ✅ . |
1 similar comment
|
@jmroot: Status check is done, and it's a success ✅ . |
|
Sorry, I can't merge this PR. Reason: |
|
Sorry, I can't merge this PR. Reason: |
|
@jmroot: Status check is done, and it's a success ✅ . |
|
Thanks @jmroot for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 4, 2021
…-23873) A compiler that doesn't define `__has_builtin` will error out when it is used on the same line as the check for it. Automerge-Triggered-By: GH:ronaldoussoren (cherry picked from commit df21f50) Co-authored-by: Joshua Root <[email protected]>
|
GH-24090 is a backport of this pull request to the 3.9 branch. |
ned-deily
pushed a commit
that referenced
this pull request
Jan 4, 2021
GH-24090) A compiler that doesn't define `__has_builtin` will error out when it is used on the same line as the check for it. Automerge-Triggered-By: GH:ronaldoussoren (cherry picked from commit df21f50) Co-authored-by: Joshua Root <[email protected]>
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 13, 2021
…-23873) A compiler that doesn't define `__has_builtin` will error out when it is used on the same line as the check for it. Automerge-Triggered-By: GH:ronaldoussoren
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A compiler that doesn't define
__has_builtinwill error out when it isused on the same line as the check for it.
https://bugs.python.org/issue42692
Automerge-Triggered-By: GH:ronaldoussoren