bpo-43705: Document that SyntaxError's offsets are 1-indexed #25153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvanrossum
reviewed
Apr 2, 2021
gvanrossum
approved these changes
Apr 2, 2021
|
@ammaraskar: Status check is done, and it's a success ✅ . |
|
Thanks @ammaraskar for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
|
GH-25155 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 2, 2021
…H-25153) Changed the inline mentions of the attributes into a proper attribute list like `SystemExit` has. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit b2a91e0) Co-authored-by: Ammar Askar <[email protected]>
|
GH-25156 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 2, 2021
…H-25153) Changed the inline mentions of the attributes into a proper attribute list like `SystemExit` has. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit b2a91e0) Co-authored-by: Ammar Askar <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Apr 2, 2021
Changed the inline mentions of the attributes into a proper attribute list like `SystemExit` has. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit b2a91e0) Co-authored-by: Ammar Askar <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Apr 2, 2021
Changed the inline mentions of the attributes into a proper attribute list like `SystemExit` has. Automerge-Triggered-By: GH:gvanrossum (cherry picked from commit b2a91e0) Co-authored-by: Ammar Askar <[email protected]>
sthagen
added a commit
to sthagen/python-cpython
that referenced
this pull request
Apr 3, 2021
bpo-43705: Document that SyntaxError's offsets are 1-indexed (pythonGH-25153)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the inline mentions of the attributes into a proper attribute list like
SystemExithas.https://bugs.python.org/issue43705
Automerge-Triggered-By: GH:gvanrossum