bpo-32266: make test_pathlib pass when working path has junctions #4778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@native-api Why did you close the PR? Did you intend to close https://bugs.python.org/issue32266 as well? |
|
I closed the PR because it was rejected as per https://bugs.python.org/issue32266#msg310412, I no longer have the machine with the setup that exposed the problem and the fix wasn't particularly elegant -- need something stock to work as I don't know if the problem is still there so don't know if the ticket can be closed. |
|
Thanks. The comment says it was too late to merge the patch in 3.4 and 3.5, I'm not sure it was rejected altogether. But if we can't test for this now it may be the case that we close the ticket and deal with the problem if and when someone else comes across it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed failures in 3.4 and 3.5, too.
In 3.4, will still fail in XP 'cuz
_getfinalpathnameis an alias tonormpaththere. There's no other API to resort to that can expand junctions save for checking every path part by hand.https://bugs.python.org/issue32266