[3.6] bpo-21060 Improve error message for "setup.py upload" without dist files (GH-5726) #5747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nGH-21060) (cherry picked from commit 08a6926) Co-authored-by: Éric Araujo <[email protected]>
merwok
approved these changes
Feb 18, 2018
|
Ok! I thought the new bpo-nnn style was recommended but the older shorter style #NNN still working. |
merwok
changed the title
|
That old style works in bpo but not in GitHub :) |
|
Yes I don’t expect github to create links to bpo but custom bots could do what they want. I prefer bug tracker-neutral references like «#1234» that humans understand over site-specific «sf1234» or the ugly «issue1234». Also I used to try to keep the first line of commit logs short! But next time I’ll follow what works with the bots. |
Mariatta
changed the title
|
@merwok: Backport status check is done, and it's a failure ❌ . |
|
PR title fixed. It needs to reference the PR on master, so bedevere can properly remove the label. |
|
@merwok: Backport status check is done, and it's a success ✅ . |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 08a6926)
Co-authored-by: Éric Araujo [email protected]
https://bugs.python.org/issue21060